PR-13: migrate coords/vectors to v2 (#454)#513
Open
charliecreates[bot] wants to merge 1 commit intocharlie/issue-454-v2-pr13-geometry-gf-group12from
Open
Conversation
|
orrery preview: https://pr-513.orrery-c4f.pages.dev/ |
Contributor
Author
There was a problem hiding this comment.
The migration is mechanically consistent, but it likely weakens validation by using an empty contract.result schema across methods. Additionally, setting global 1e-12 tolerances introduces a potentially flaky behavioral change for trig/angle-heavy transforms. Finally, switching from an explicit uses: workflows/legacy/coords-vectors.basic@v1 to an unparameterized invokeLegacyCall risks subtle parity semantics drift if defaults differ.
Summary of changes
What changed
- Migrated coords/vectors parity-checking method specs from v1 to v2 schema across multiple methods.
- For each method, removed the
@v1.ymlspec and added a new@v2.ymlspec with:schemaVersion: 2manifestmetadata (id,kind)contractsection (contractMethod,canonicalMethod,aliases, and a placeholderresultschema)defaults.comparetolerances (tolAbs/tolRelset to1e-12)workflow.stepsusingop: invokeLegacyCall- The same
cases/args/expectcontent as before (plus preserved per-casecompareoverrides likeangleWrapPi: true).
Files affected
- Replaced v1 specs with v2 equivalents for:
axisar,georec,latrec,mtxv,mxm,mxv,recgeo,reclat,recsph,rotate,rotmat,sphrec,vadd,vcrss,vdot,vhat,vminus,vnorm,vscl,vsub.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack step PR-13 in the issue #454 migration chain.