Skip to content

PR-13: migrate coords/vectors to v2 (#454)#513

Open
charliecreates[bot] wants to merge 1 commit intocharlie/issue-454-v2-pr13-geometry-gf-group12from
charlie/issue-454-v2-pr14-migrate-coords-vectors-v2
Open

PR-13: migrate coords/vectors to v2 (#454)#513
charliecreates[bot] wants to merge 1 commit intocharlie/issue-454-v2-pr13-geometry-gf-group12from
charlie/issue-454-v2-pr14-migrate-coords-vectors-v2

Conversation

@charliecreates
Copy link
Contributor

Stack step PR-13 in the issue #454 migration chain.

@github-actions
Copy link

orrery preview: https://pr-513.orrery-c4f.pages.dev/

Copy link
Contributor Author

@charliecreates charliecreates bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The migration is mechanically consistent, but it likely weakens validation by using an empty contract.result schema across methods. Additionally, setting global 1e-12 tolerances introduces a potentially flaky behavioral change for trig/angle-heavy transforms. Finally, switching from an explicit uses: workflows/legacy/coords-vectors.basic@v1 to an unparameterized invokeLegacyCall risks subtle parity semantics drift if defaults differ.

Summary of changes

What changed

  • Migrated coords/vectors parity-checking method specs from v1 to v2 schema across multiple methods.
  • For each method, removed the @v1.yml spec and added a new @v2.yml spec with:
    • schemaVersion: 2
    • manifest metadata (id, kind)
    • contract section (contractMethod, canonicalMethod, aliases, and a placeholder result schema)
    • defaults.compare tolerances (tolAbs/tolRel set to 1e-12)
    • workflow.steps using op: invokeLegacyCall
    • The same cases/args/expect content as before (plus preserved per-case compare overrides like angleWrapPi: true).

Files affected

  • Replaced v1 specs with v2 equivalents for:
    • axisar, georec, latrec, mtxv, mxm, mxv, recgeo, reclat, recsph, rotate, rotmat, sphrec, vadd, vcrss, vdot, vhat, vminus, vnorm, vscl, vsub.

@charliecreates charliecreates bot removed the request for review from CharlieHelps February 22, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant