-
Notifications
You must be signed in to change notification settings - Fork 0
Cleanup, Refactoring, & Rewriting #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ryanwilsond
wants to merge
234
commits into
staging
Choose a base branch
from
rw/cleanup
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does not change language functionality (apart from fixing unintended behavior/bugs) (mostly), hence the Syntax API was not modified (mostly). All this PR aims to do is clean up the codebase as a whole and restructure how certain things work to be cleaner, as over the past few months the code has gotten increasingly messy as many "quick solutions" have been incorporated.
This is in prep for adding class properties (getters, setters, indexers), and the graphics library.
The major refactoring of the Binding and Symbol APIs is due to how the previous system was mishandling nested template arguments.
Reworks:
BoundType->BoundTypeExpressionBoundTypetoTypeSymbolTypeWithAnnotationsandTypeOrConstantto replace the current template arguments systemT extends ...: T is or inherits from the given type, not just inherits fromT is ...: T is the given constraint, eitherT is primitiveorT is notnullUpdated C# transpiler to support all new features added in the recent months(this will be done in another PR)Updated the IL emitter to work with all new features(this will be done in another PR)Added debugging(this will be added in another PR)samples/to demonstrate new featuresrefexpressions are now invalid expression terms (which they should have already been, so I'm not counting this as a syntax change)BuiltinFunctionsandPrimitiveTypeSymbolwithCorLibraryNow using C#CancellationTokens instead ofValueWrapper<T>work around