This repository was archived by the owner on Mar 25, 2026. It is now read-only.
fix: update E2E tests to use correct port configuration#71
Closed
ryanrozich wants to merge 1 commit intorelease/v0.2.0-rc2from
Closed
fix: update E2E tests to use correct port configuration#71ryanrozich wants to merge 1 commit intorelease/v0.2.0-rc2from
ryanrozich wants to merge 1 commit intorelease/v0.2.0-rc2from
Conversation
- Update demo-deployment tests to use E2E_PORT env variable (default 5173) - Fix hardcoded localhost:5173 URLs to use relative paths - Ensure all tests work with dynamic port configuration - Tests now properly support dev server on any port via E2E_PORT
github-actions
bot
added
status: in-code-review
|
🚀 Demo Preview Ready! Preview URL: https://demo.rozich.net/ag-grid-react-components-pr-71/ This preview will be available for testing until the PR is merged or closed. |
Owner
Author
|
This PR has been superseded by #102 (Release v0.2.0-rc3). The E2E tests need a fresh approach for the new headless components architecture. A new issue will be created to track E2E testing for headless components. See HEADLESS_RC3_MIGRATION_PLAN.md for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
E2E_PORTenvironment variableChanges
demo-deployment.spec.tsto useE2E_PORTenv variable (default 5173)Test Results
Before: Tests were failing due to port mismatch (looking for port 3000/5173 when server was on 5174)
After: Demo deployment tests now pass (5/8 passing, 3 have other issues unrelated to port)
Testing
Run tests with custom port:
🤖 Generated with Claude Code