Add characters_ignoring_modifiers to get chars ignoring modifiers on keyup/down events#136
Open
eugenesvk wants to merge 1 commit intoryanmcgrath:trunkfrom
Open
Add characters_ignoring_modifiers to get chars ignoring modifiers on keyup/down events#136eugenesvk wants to merge 1 commit intoryanmcgrath:trunkfrom
eugenesvk wants to merge 1 commit intoryanmcgrath:trunkfrom
Conversation
eugenesvk
force-pushed
the
fr-char-no-mod
branch
from
bc80dec to
021d3ee
Compare
Contributor
Author
|
rebased The formatting checks/tests seem to run and fail on all the code in the repo, not specific to this, so not sure what to fix here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy&pasted the existing
pub fn characters(&self)with a different constanthttps://developer.apple.com/documentation/appkit/nsevent/1524605-charactersignoringmodifiers
(btw, is
characters_ignoring_modifiersverbose really better to read vschars_no_mods(the verbosity level ofconstraint_greater_than_or_equal_tomakes it worse imo)