Add support for mTLS #2764
Merged
Add support for mTLS #2764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds mutual TLS (mTLS) support to enable client certificate verification. When configured, the server will require clients to present valid certificates signed by a specified Certificate Authority (CA).
Changes:
- Added
mtlsCaconfiguration option across CLI, server interface, and main entry point - Implemented validation to ensure mTLS requires TLS to be enabled
- Added comprehensive documentation for configuring and using mTLS
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/server.ts | Added mtlsCa option to server interface and HTTPS configuration with client certificate validation settings |
| lib/cli.ts | Added CLI option and validation for mTLS CA certificate file |
| index.ts | Passed through mtlsCa option and enhanced logging to indicate TLS/mTLS status |
| docs/configuration.md | Added documentation for the new --mtls-ca option and usage examples |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.