Skip to content

Conversation

@ryanfowler
Copy link
Owner

No description provided.

@ryanfowler ryanfowler requested a review from Copilot January 28, 2026 01:36
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for mutual TLS (mTLS) authentication by introducing --cert and --key flags that allow users to specify client certificates and private keys for secure connections.

Changes:

  • Added new configuration fields for client certificates and keys, with support for both separate and combined PEM files
  • Updated HTTP client to use provided client certificates for mTLS connections
  • Added comprehensive integration tests covering various mTLS scenarios including success cases, error handling, and file validation

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
main.go Parses client certificate configuration and passes it to the HTTP request
internal/fetch/fetch.go Adds ClientCert field to Request struct and passes it to the HTTP client
internal/config/config.go Implements certificate/key parsing, validation, and merging logic with custom error types
internal/complete/complete.go Adds cert and key flags to file path completion
internal/client/client.go Configures TLS with client certificates for mTLS authentication
internal/cli/app.go Defines cert and key CLI flags with validation and requirement constraints
integration/integration_test.go Adds comprehensive mTLS integration tests with certificate generation and server setup
docs/CONFIG.md Documents mTLS configuration options with examples

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ryanfowler ryanfowler merged commit 5bdf978 into main Jan 28, 2026
10 checks passed
@ryanfowler ryanfowler deleted the mtls branch January 28, 2026 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants