Skip to content

Refactor e-command argument code #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tcunha wants to merge 42 commits into
base: master
Choose a base branch
from
Open

Refactor e-command argument code #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
16a45c3
Avoid exiting if the home directory isn't known.
Feb 21, 2013
13792bc
Don't destroy an uninitialised user interface.
Feb 21, 2013
f0bbf50
Add functions to output a message to stderr.
Feb 21, 2013
beec982
Use newly added functions.
Feb 21, 2013
100fb96
Remove includes from the header files.
Feb 21, 2013
02805ac
Add missing includes.
Feb 21, 2013
4135b87
Replace special errx(3) call with new function.
Feb 22, 2013
0b5e57d
Add missing format argument.
Feb 22, 2013
8ab1902
Start adding support for error context.
Feb 22, 2013
8bdd03f
Add configuration file error context.
Feb 22, 2013
1553ab4
Add paint error context.
Feb 22, 2013
4978fa2
Add verbose command-line option.
Feb 22, 2013
f49976a
Add functions to output a debug message.
Feb 22, 2013
14605ed
Zap DEBUG macro.
Feb 22, 2013
73c5096
Use new error functions.
Feb 22, 2013
8e153b8
Sprinkle some const.
Feb 22, 2013
431a68d
Take advantage of the -I compiler option.
Feb 22, 2013
d2b6c36
Remove last calls to the paint functions.
Feb 22, 2013
1028a29
Add functions that always exit when called.
Feb 22, 2013
06216ad
Add wrappers of functions that allocate memory.
Feb 22, 2013
07058a7
Remove superfluous bzero(3) calls.
Feb 22, 2013
0719724
Use new wrapper functions.
Feb 23, 2013
e112d94
Do not allocate a zero size object.
Feb 23, 2013
e048f28
Move example file to its own directory.
Feb 23, 2013
125db86
Remove extension for consistency.
Feb 23, 2013
e50cf67
Do not use uninitialised variables.
Feb 23, 2013
1523622
Take advantage of the execute command function.
May 10, 2013
7f7f265
Print the configuration file and line number.
May 14, 2013
82414d4
While at it, simplify configuration file parsing.
May 14, 2013
00ba92f
Do not output the path twice.
May 14, 2013
9646532
Add accepted character options to the structure.
May 31, 2013
952171b
Add function that copies arguments.
May 31, 2013
08e77c3
Fix off-by-one. It would occur on zero arguments.
May 31, 2013
7e915e8
Add e-command generic getopt arguments support.
May 31, 2013
6418ee8
Simplify printing an e-command usage.
May 31, 2013
db1891d
Skip e-command name.
Jun 1, 2013
274e750
Unhook parse function.
Jun 1, 2013
5724927
Functions should now use the arguments structure.
Jun 1, 2013
2225322
Use arguments empty function.
Jun 1, 2013
149a8df
Use new arguments functions.
Jun 1, 2013
06732af
Remove parse functions.
Jun 1, 2013
dfeb5f6
Add tree header file from OpenBSD.
Jun 6, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 DEVELOPERS.txt → DEVELOPERS
View file
Open in desktop
File renamed without changes.
18 changes: 9 additions & 9 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,19 +11,20 @@ LDEPS=$(TAGLIB_LIBS) $(GSTREAMER_LIBS)
ODEPS=$(GSTREAMER_OBJS)

# build variables
CC ?= /usr/bin/cc
CFLAGS += -c -std=c89 -Wall -Wextra -Wno-unused-value $(CDEBUG) $(CDEPS)
LIBS += -lm -lncurses -lutil $(LDEPS)
CC ?= /usr/bin/cc
CPPFLAGS += -I. -Icompat -Iplayers -iquote.
CFLAGS += -c -std=c89 -Wall -Wextra -Wno-unused-value $(CDEBUG) $(CDEPS)
LIBS += -lm -lncurses -lutil $(LDEPS)

# object files
OBJS=commands.o compat.o ecmd.o \
OBJS=commands.o compat.o ecmd.o ecmd_args.o \
ecmd_add.o ecmd_addurl.o ecmd_check.o \
ecmd_flush.o ecmd_help.o ecmd_init.o \
ecmd_rmfile.o ecmd_tag.o ecmd_update.o \
keybindings.o medialib.o meta_info.o \
error.o keybindings.o medialib.o meta_info.o \
mplayer.o paint.o player.o player_utils.o \
playlist.o socket.o str2argv.o \
uinterface.o vitunes.o \
uinterface.o vitunes.o xmalloc.o \
$(ODEPS)

# subdirectories with code (.PATH for BSD make, VPATH for GNU make)
Expand All @@ -39,10 +40,10 @@ vitunes: $(OBJS)
$(CC) -o $@ $(LDFLAGS) $(OBJS) $(LIBS)

.c.o:
$(CC) $(CFLAGS) $<
$(CC) $(CPPFLAGS) $(CFLAGS) $<

debug:
make CDEBUG="-DDEBUG -g"
make CDEBUG="-g"

clean:
rm -f *.o
Expand Down Expand Up @@ -93,4 +94,3 @@ reports: report.mandoc report.cppcheck report.scan-build
@figlet "Static Checks Complete"
cat report.mandoc
cat report.cppcheck

Loading