Skip to content

Add table name to validation errors.#180

Open
andyday wants to merge 1 commit intoryanfitz:masterfrom
andyday:master
Open

Add table name to validation errors.#180
andyday wants to merge 1 commit intoryanfitz:masterfrom
andyday:master

Conversation

@andyday
Copy link

@andyday andyday commented Jun 29, 2016

When validation (joi) errors occur there is no context to help determine what table the error occurred on. This small pull request fixes this. The more robust approach would be to extend Error and add table as a property and then modify the toString function, but that may be more than is needed.

@clarkie
Copy link

clarkie commented Jul 15, 2016

Would you like this ported to https://github.com/clarkie/dynogels

@andyday
Copy link
Author

andyday commented Jul 15, 2016

@clarkie sure. what's been added to this over vogels?

@clarkie
Copy link

clarkie commented Jul 15, 2016

Not a lot as yet but I'm working on it. I've updated joi bit still need to go to v9.

@clarkie
Copy link

clarkie commented Jul 18, 2016

Merged into dynogels. But now I'm confused as to what version to bump: http://stackoverflow.com/questions/38432774/semver-on-nested-object-in-javascript-major-minor-or-patch

@clarkie
Copy link

clarkie commented Jul 18, 2016

Released as part of Dynogels v5.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants