Skip to content

Handle qualified asterisk in SELECT#54

Merged
ryancinsight merged 1 commit intomainfrom
qualified-asterisk-support-16790345586847993377
Jan 11, 2026
Merged

Handle qualified asterisk in SELECT#54
ryancinsight merged 1 commit intomainfrom
qualified-asterisk-support-16790345586847993377

Conversation

@google-labs-jules
Copy link
Contributor

@google-labs-jules google-labs-jules bot commented Jan 10, 2026

Implemented support for parsing qualified asterisks (e.g., SELECT table.*) in SQL SELECT statements. This involved extending the AST with a QualifiedAsterisk variant for SelectColumn, enhancing the parser logic to recognize identifiers followed by a dot and an asterisk, and ensuring downstream components like the translator and optimizer can handle the new variant without panicking (though full expansion logic remains TODO as per existing patterns). Verified with unit tests.


PR created automatically by Jules for task 16790345586847993377 started by @ryancinsight

High-level PR Summary

This PR adds support for parsing qualified asterisk syntax (e.g., SELECT table.*) in SQL SELECT statements. The implementation extends the AST with a new QualifiedAsterisk variant, updates the parser to recognize the pattern of identifier followed by dot and asterisk, and ensures the translator and optimizer handle the new variant gracefully. The full expansion logic for qualified asterisks is left as a TODO, consistent with existing patterns in the codebase.

⏱️ Estimated Review Time: 5-15 minutes

💡 Review Order Suggestion
Order File Path
1 src/core/query/sql/ast.rs
2 src/core/query/sql/parser/expression.rs
3 src/core/query/sql/tests/parser_tests.rs
4 src/core/query/sql/translator.rs
5 src/core/optimizer/mod.rs

Need help? Join our Discord

- Added `QualifiedAsterisk` variant to `SelectColumn` in AST.
- Updated `SqlParser` to parse `table.*` patterns correctly.
- Patched `translator.rs` and `optimizer/mod.rs` to handle the new `QualifiedAsterisk` variant.
- Added tests in `parser_tests.rs` to verify qualified asterisk parsing.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai
Copy link

coderabbitai bot commented Jan 10, 2026

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@recurseml recurseml bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by RecurseML

🔍 Review performed on 8d5f078..9f05e9b

✨ No bugs found, your code is sparkling clean

✅ Files analyzed, no issues (5)

src/core/optimizer/mod.rs
src/core/query/sql/ast.rs
src/core/query/sql/parser/expression.rs
src/core/query/sql/tests/parser_tests.rs
src/core/query/sql/translator.rs

@ryancinsight ryancinsight marked this pull request as ready for review January 11, 2026 05:40
@ryancinsight ryancinsight merged commit c62aae8 into main Jan 11, 2026
2 of 4 checks passed
@ryancinsight ryancinsight deleted the qualified-asterisk-support-16790345586847993377 branch January 11, 2026 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant