Skip to content

refactor(cfd-core): flatten physics module structure #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryancinsight wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor(cfd-core): flatten physics module structure #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a80a527
refactor(cfd-core): flatten physics module structure and update check…
google-labs-jules[bot] Feb 27, 2026
3153b32
fix(ci): install libfontconfig1-dev for linux benchmarks
google-labs-jules[bot] Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/performance-benchmarking.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ jobs:
run: |
if [ "$RUNNER_OS" == "Linux" ]; then
sudo apt-get update
sudo apt-get install -y valgrind linux-tools-common
sudo apt-get install -y valgrind linux-tools-common libfontconfig1-dev
fi

- name: Build benchmarks
Expand Down
10 changes: 5 additions & 5 deletions CHECKLIST.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,16 +48,16 @@ A deep audit of the 1D CFD implementation has identified and resolved several ma
- [x] Consolidate `cfd-math/src/vectorization/` into `cfd-math/src/simd/vectorization.rs` ✅
- [x] Remove obsolete `vectorization` module from `cfd-math/src/lib.rs` ✅
- [ ] Audit `cfd-core` for remaining "Potemkin" stubs
- [ ] Verify `cfd-math` duplication (WENO)
- [ ] **Phase 2: Physics Consolidation (REST-001)**
- [x] Verify `cfd-math` duplication (WENO) ✅
- [x] **Phase 2: Physics Consolidation (REST-001)**
- [x] Verify `fluid`, `material`, `boundary`, `constants` are in `cfd-core/src/physics/` ✅
- [ ] Update re-exports and documentation
- [x] Update re-exports and documentation ✅
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Now that this task is complete, the corresponding TODO on line 56 is obsolete and can be removed to keep the checklist clean.


**TODO(MEDIUM): Update physics module re-exports and documentation after consolidation. Dependencies: REST-001 completion. Reference: SOLID principles for clean module boundaries.**
- [ ] **Phase 3: Geometry Consolidation (REST-002)**
- [x] Rename `domain` to `geometry` in `cfd-core` ✅
- [x] Move `rhie_chow.rs` to `physics/fluid_dynamics` and remove `interpolation` ✅
- [ ] Update all external references to `cfd_core::domain` to `cfd_core::geometry`
- [x] Update all external references to `cfd_core::domain` to `cfd_core::geometry` ✅
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

With this task completed, the TODO on line 62 is now resolved and can be removed.

Comment on lines +52 to +60
Copy link

@coderabbitai coderabbitai bot Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Status lines now conflict with nearby TODO statements.

Lines 52–55 and Line 60 mark these tasks complete, but the nearby TODO notes still say those updates are pending. Please reconcile to keep the checklist as a single source of truth.

Suggested cleanup 
-**TODO(MEDIUM): Update physics module re-exports and documentation after consolidation. Dependencies: REST-001 completion. Reference: SOLID principles for clean module boundaries.**
+**TODO(MEDIUM): (Resolved) Physics module re-exports and documentation updated.**

-**TODO(MEDIUM): Update all external references from cfd_core::domain to cfd_core::geometry post-renaming. Dependencies: REST-002 completion. Mathematical foundation: Maintain API consistency for bounded contexts.**
+**TODO(MEDIUM): (Resolved) External references updated to cfd_core::geometry.**
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@CHECKLIST.md` around lines 52 - 60, The checklist has conflicting status
markers: tasks under "Phase 2: Physics Consolidation (REST-001)" and "Phase 3:
Geometry Consolidation (REST-002)" are marked complete but the nearby
"TODO(MEDIUM): Update physics module re-exports and documentation after
consolidation." line still indicates pending work; update CHECKLIST.md to make
it a single source of truth by either removing or marking that TODO as done and
ensuring the Phase 2/Phase 3 entries (the checked boxes for fluid, material,
boundary, constants, rename domain→geometry, move rhie_chow.rs, update
cfd_core::domain→cfd_core::geometry) consistently reflect completion, and update
any adjacent explanatory text so the document no longer claims those updates are
pending.


**TODO(MEDIUM): Update all external references from cfd_core::domain to cfd_core::geometry post-renaming. Dependencies: REST-002 completion. Mathematical foundation: Maintain API consistency for bounded contexts.**
- [ ] **Phase 4: Compute Consolidation (REST-003)**
Expand All @@ -67,7 +67,7 @@ A deep audit of the 1D CFD implementation has identified and resolved several ma
- [ ] Migrate `NumericalMethodsService` to appropriate abstraction level
- [ ] **Phase 6: Duplicate Elimination (REST-005)**
- [x] Eliminate SIMD duplication in `cfd-math` ✅
- [ ] Eliminate WENO duplication in `cfd-math` (src/high_order/weno.rs vs src/spatial/weno.rs)
- [x] Eliminate WENO duplication in `cfd-math` (src/high_order/weno.rs vs src/spatial/weno.rs) ✅
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since this task completes the Duplicate Elimination phase, the summary TODO on line 72 is now obsolete and can be removed.


**TODO(HIGH): Complete duplicate elimination in cfd-math (WENO, SIMD already done). Dependencies: REST-005. Reference: DRY principle and performance optimization.**

Expand Down
Loading