Add Dataset unit tests and fix datavector indexing bug #63
Conversation
- Added `TestDatasetDeterministic` to `test/test_dataset.py` with weighted and unweighted test cases for `project` and `datavector`. - Fixed a bug in `Dataset.datavector` where `np.ravel_multi_index` used Fortran order (`order='F'`) while `reshape` used default C-order, causing incorrect unflattening of data vectors. Changed to `order='C'`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
Added deterministic unit tests for Dataset.project and Dataset.datavector, which revealed a bug in datavector's indexing order. Fixed the bug by switching from Fortran-order to C-order indexing in ravel_multi_index to match numpy's default reshape behavior.
PR created automatically by Jules for task 3233401077806398879 started by @ryan112358