Skip to content

Fix miscalculation of quarter numbers #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fakemonster wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix miscalculation of quarter numbers #44

fakemonster wants to merge 1 commit into from

Conversation

@fakemonster
Copy link

@fakemonster fakemonster commented Apr 15, 2025

This PR does a few things:

  1. fixes a bug in quarter calculations. I ran into this finding that a November date came out as "Q3", rather than "Q4"!
  2. adds an additional test to cover the previously failing case
  3. extends the fuzzer range to 18 months, since the current fuzzer range is a little too narrow to fail (it only covers January, which gets "good" quarter numbers already)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@fakemonster