Skip to content

Layer base get out data, use dim tags and correct batch#609

Closed
albertz wants to merge 1 commit intomasterfrom
albert-tmp-layer-base-data-dim-tags
Closed

Layer base get out data, use dim tags and correct batch#609
albertz wants to merge 1 commit intomasterfrom
albert-tmp-layer-base-data-dim-tags

Conversation

@albertz
Copy link
Member

@albertz albertz commented Sep 1, 2021

No description provided.

@albertz albertz force-pushed the albert-tmp-layer-base-data-dim-tags branch from 4a042a9 to c23e6b1 Compare September 2, 2021 06:01
@albertz

This comment has been minimized.

@albertz
Copy link
Member Author

albertz commented Sep 2, 2021

test_attention_no_encoder_dependency fails:

returnn: INFO: TensorFlow exception: assertion failed: [Data(name=\'prev:accum_att_weights_output\', batch_shape_meta=[B&Beam{\'output/prev:output\'}(4),F|F\'att_energy:feature-dense\'(1),T|\'enc time\'[B]])] [shape] [8 1 5] [dyn_size[2]] [5 5] [.shape] [2] [-> invalid shape(dyn_size[2]) or invalid batch dim] [8]
	 [[node output/rec/prev__accum_att_weights/runtime_sanity_check/Assert_3/Assert (defined at home/runner/work/returnn/returnn/returnn/tf/util/data.py:1378) ]]

This should have been fixed by better dim tag batch handling and automatic beam expansion (#613).

@albertz albertz force-pushed the albert-tmp-layer-base-data-dim-tags branch from c23e6b1 to fa55706 Compare September 2, 2021 13:40
@albertz
Copy link
Member Author

albertz commented Sep 2, 2021

Ok, after a rebase, still this:

InvalidArgumentError: assertion failed: [Data(name=\'prev:accum_att_weights_output\', batch_shape_meta=[B&Beam{\'output/prev:output\'}(4),F|F\'att_energy:feature-dense\'(1),T|\'enc time\'[B]])] [shape] [8 1 5] [dyn_size[2]] [5 5] [.shape] [2] [-> invalid shape(dyn_size[2]) or invalid batch dim] [8]
	 [[{{node output/rec/prev__accum_att_weights/runtime_sanity_check/Assert_3/Assert}}]]

Which still looks like #613.

@albertz
Copy link
Member Author

albertz commented Sep 2, 2021

Still the same after rebase:

InvalidArgumentError: assertion failed: [Data(name=\'prev:accum_att_weights_output\', batch_shape_meta=[B&Beam{\'output/prev:output\'}(4),F|F\'att_energy:feature-dense\'(1),T|\'enc time\'[B]])] [shape] [8 1 5] [dyn_size[2]] [5 5] [.shape] [2] [-> invalid shape(dyn_size[2]) or invalid batch dim] [8]
	 [[{{node output/rec/prev__accum_att_weights/runtime_sanity_check/Assert_3/Assert}}]]

@albertz
Copy link
Member Author

albertz commented Sep 2, 2021

This was part of #613 now.

@albertz albertz closed this Sep 2, 2021
@albertz albertz deleted the albert-tmp-layer-base-data-dim-tags branch September 2, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant