OggZipDataset: normalize // to / when reading files from archive#1624
Open
NeoLegends wants to merge 10 commits intomasterfrom
Open
OggZipDataset: normalize // to / when reading files from archive#1624NeoLegends wants to merge 10 commits intomasterfrom
OggZipDataset: normalize // to / when reading files from archive#1624NeoLegends wants to merge 10 commits intomasterfrom
Conversation
The dataset implementation joins some paths wrongly at times, leading to double slashes breaking lookup in the zip file, even though there is a file at that path. By normalizing // to / the file can be read properly.
Member
|
This sounds like a bug in the dataset preparation pipeline? And there are also much more cases how it could be wrong, e.g. having |
Member
|
What is the status here? Was this just a bug in the dataset preparation pipeline, as I assumed? So then just fix the dataset preparation pipeline, and this here is not needed? |
… into NeoLegends-patch-1
… into NeoLegends-patch-1
Member
|
Why is this still open? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dataset implementation joins some (potentially empty) paths, sometimes leading to double slashes in the resulting paths. This can break lookup in the zip file, even though there is a file at that path. By normalizing // to / the file can be read from the archive properly. On normal file systems this usually isn't a problem, because they also do this.