Add new constructor for Speech::ModelCombination to get config for specific model index#182
Draft
Add new constructor for Speech::ModelCombination to get config for specific model index#182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a preparation of my one-pass model-combination algorithm which requires not only multiple label scorers, but also an individual lexicon per label scorer (and optionally an individual AM config). In this PR, a new constructor for Speech::ModelCombination is added which additional takes a modelIndex and retrieves the lexicon, AM and label scorer defined in the config for this index, e.g. like this:
If no individual lexicon or AM is defined, it falls back to the global lexicon or AM.
In Core::Configuration, two new helper functions are added. The first checks if at least one resource under a certain selection is defined and the second returns the parent config for a selection.
I'm happy about any suggestions or ideas how to improve this code.