Open
Conversation
hannah220
reviewed
Nov 12, 2025
| } | ||
|
|
||
| // Re-use previous hidden-state but mark that finalization (i.e. hidden-state update) is required | ||
| auto newScoringContext = Core::ref(new StepOnnxHiddenStateScoringContext(scoringContext->currentStep + timeIncrement, std::move(newLabelSeq), scoringContext->hiddenState)); |
Contributor
There was a problem hiding this comment.
You could directly add requiresFinalize in the constructor above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new label scorer class
StatefulTransducerOnnxLabelScorer. This is similar to theStatefulOnnxLabelScorerbut hidden-state and encoder features are decoupled. Here, the state initializer and state updater only take tokens and no encoder features. Instead, the scorer receives the encoder state at the current time step and the hidden state and is supposed to combine the two.This can be used for transducer models with unlimited context.
Depends on #144.