You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think following torch.nn.utils.weight_norm or torch.nn.utils.parametrizations.weight_norm for this makes more sense, or not? This doesn't need to be (or rather should not be) specific for one module (here it is specific to torch.nn.Linear) but it should be generic, and less hacky, and simpler.
I think following torch.nn.utils.weight_norm or torch.nn.utils.parametrizations.weight_norm for this makes more sense, or not? This doesn't need to be (or rather should not be) specific for one module (here it is specific to torch.nn.Linear) but it should be generic, and less hacky, and simpler.
@albertz but here we can also use the WeightDrop class to wrap other torch.nn.Module like this
Ah sorry I misread the code regarding nn.Linear. You are right, your WeightDrop is generic. But I still think it's too complicated and too hacky and non-PyTorch like compared to how torch.nn.utils.weight_norm or torch.nn.utils.parametrizations.weight_norm works. I would follow standard PyTorch code (like torch.nn.utils.weight_norm or torch.nn.utils.parametrizations.weight_norm), i.e. add weight dropout just in the same way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the weight dropout