Skip to content

Keep N last package metadata #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
piterpunk wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Keep N last package metadata #34

piterpunk wants to merge 3 commits into from

Conversation

@piterpunk
Copy link
Collaborator

@piterpunk piterpunk commented Apr 18, 2023

This PR implements:

  • A function to remove the installation scripts and the list of files from older versions of upgraded packages.
  • The KEEP_N_LAST_PKG_METADATA variable to govern the function behaviour
  • Documentation about this new variable

Closes #33

pete4abw and others added 3 commits April 18, 2023 17:03
@pete4abw
Update slackpkg.conf.new and slackpkg.conf.5
b1b9d2d 
- Show DOWNLOADER options for curl usage.
- Update manpage date and slackpkg version.
Minor formatting fixes
724f444
Allows automatic cleanup of updated packages data
201eed9 
When a package is upgraded, its old installation scripts and list
of files are kept under /var/lib/pkgtools. This commit implements
the function to remove those lists and scripts, the variable to
govern its behaviour and the documentation about it.
@piterpunk piterpunk requested a review from rworkman April 18, 2023 22:37
@opty77
Copy link

opty77 commented Apr 21, 2023

Please keep this disabled by default like now forever and add confirmation for sure.

@piterpunk
Copy link
Collaborator Author

piterpunk commented Apr 23, 2023

Please keep this disabled by default like now forever and add confirmation for sure.

It is disabled by default. Will only be activated if the KEEP_N_LAST_PKG_METADATA is set.

@piterpunk piterpunk mentioned this pull request Apr 23, 2023
Open
@opty77
Copy link

opty77 commented May 26, 2023

I know, I just wanted to make paranoidly sure.

I see a potential problem with DST or moving between timezones in general when using the timestamp from file name.

(Note to self: Five week debt paid back. \o/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rworkman rworkman Awaiting requested review from rworkman

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The removed_scripts and removed_packages directories can use a lot of disk space

3 participants

@piterpunk @opty77 @pete4abw