Increase size limit for ServerJoinDataPacket #767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notfood
added
fix
Member
|
Any idea why the packets are getting so big? |
Author
|
I don't think this packet has changed in size, it's just that previously there was no limit on it's size, and now there is. As for what's taking so much space, I believe that it's just from the amount of mods (the issue report had over 100 of them). For each mod we write it's data (JoinData.WriteServerData) which contains things like: name (and some metadata), all of their file paths and hashes, and configs. I'd guess that the file paths are probably the biggest. I plan to analyze some packets more in-depth later on and hopefully reduce their size |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue report. Might be related to #763