Simplify method name normalization #747
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using
mono_debug_print_stack_framefor trace method names, just usemono_method_get_reflection_namewhich is internally used by the first method anyway. The method normalization that is performed is mostly just removing the extra stuff thatdebug_print_stack_frameadds and converting it back toget_reflection_name. It's simpler and less brittle to just use the method directly.debug_print_stack_frameis still used for stack traces in desyncs, this only changes the way we get the method name used by trace hashes.Example output of the new
Dump addr info tabledebug action that shows: in the first column (NORM:) the normalized name (usingget_reflection_name), the hash (H:), and the full name (R:usingdebug_print_stack_frame)