Fix ping always showing 0ms when connecting without using LiteNetLib #529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The root of the issue is that the keepAliveTimer was only started once when creating the ServerPlayer and then always just `Reset()` which does not start it again. The timer was only ever started once and then reset while not having counted any time. To test this remove ServerPlayingState:194 (if connection is LNL: return) and OnNetworkLatencyUpdate in NetworkingLiteNet As a drive-by improvement I added some minor comments nearby.
mibac138
commented
Apr 2, 2025
Comment on lines
+81
to
+84
| if (!keepAliveTimer.IsRunning) | ||
| { | ||
| keepAliveTimer.Start(); | ||
| } |
Author
There was a problem hiding this comment.
Generally, this if is redundant as starting a already running Stopwatch is a no-op (i.e. doesn't reset it) but I feel this conveys intention better (my intuition would be that this always starts the timer from 0 and doesn't just keep running with the same time if already started).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root of the issue is that the keepAliveTimer was only started once when creating the ServerPlayer and then always just
Reset()which does not start it again. The timer was only ever started once and then reset while not having counted any time.To test this remove ServerPlayingState:194 (if connection is LNL: return) and OnNetworkLatencyUpdate in NetworkingLiteNet (or just connect using Steam)
As a drive-by improvement I added some minor comments nearby.