Open
Conversation
This is required for later commits. v1.63 was released 2.5 years ago and is included in Debian Bookworm.
As explained by the release announcement [1] this stops optional dependencies from becoming features by themselves, which is misleading given that they don't enable anything and exposes implementation details. [1]: https://blog.rust-lang.org/2022/04/07/Rust-1.60.0.html#new-syntax-for-cargo-features
This is free given that the MSRV is high enough. I've also tried to remove imports from types which are now part of the prelude.
paolobarbolini
force-pushed
the
improvements
branch
from
c51206f to
2be73d2
Compare
Fixes the warning introduced by https://blog.rust-lang.org/2024/05/06/check-cfg.html
This helps the MSRV aware resolver pick a version compatible with the project. This version is also displayed by crates.io, which is nice. It may also obsolete the versions table in README.md given that crates.io shows the `rust-version` field in the versions history page, for example: https://crates.io/crates/tokio/versions
This seems to be ar artifact of how `extern crate` was needed in Rust 2015 edition.
This has not been required for a long time [1]. [1]: https://blog.rust-lang.org/2018/12/06/Rust-1.31-and-rust-2018.html#module-system-changes
This has been the default for a long time. crates.io and lib.rs already assume docs.rs to be the URL for docs.
paolobarbolini
force-pushed
the
improvements
branch
from
2be73d2 to
6d26869
Compare
Contributor
Author
|
Ping @SergioBenitez |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is best reviewed commit-by-commit.