-
Notifications
You must be signed in to change notification settings - Fork 193
[WIP] Rampages #675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Rampages #675
Conversation
Codecov Report
@@ Coverage Diff @@
## master #675 +/- ##
==========================================
- Coverage 11.13% 11.09% -0.05%
==========================================
Files 252 252
Lines 22941 23034 +93
Branches 5794 5807 +13
==========================================
+ Hits 2554 2555 +1
- Misses 18856 18946 +90
- Partials 1531 1533 +2
Continue to review full report at Codecov.
|
| const std::array<int32_t, 4>& modelsToKill, | ||
| const bool headshot) { | ||
| // TODO: Document why | ||
| if (gxtEntry != "PAGE_00") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 2 missions (Trial By Fire, Uzi Money) that use init_rampage opcode for their own purposes. They pass custom onscreen message, and there is a check if message isn't default then it's special mission rampage initialization, so don't increment rampagesPassed stat, because that's not a real rampage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know, thank you - going to document that appropriately.
Nice to still see you around!
| endif() | ||
|
|
||
| if(CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang") | ||
| if(CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang" AND CMAKE_TARGET STREQUAL "Xcode") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this (still) work?
ORWSRC=# paste path to your source here
mkdir /tmp/orwbin
cd /tmp/orwbin
CC=$(xcodebuild -find clang) CXX=$(xcodebuild -find clang++) cmake "$ORWSRC" "-GUnix Makefiles"
make -j9
| uint32_t baseBrief; | ||
| }; | ||
|
|
||
| class Rampage { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Rampage should get its own file.
Revive of #592.
Though I could start working on this. For now just rebased on current master.