Skip to content

Conversation

@christoph-heiss
Copy link
Contributor

Revive of #592.

Though I could start working on this. For now just rebased on current master.

  • Draw HUD
  • Trigger OnCharacterDie event
  • onVehicleWreck event
  • Model IDs -1 ALL PEDS -2 ALL CARS handle this

@codecov
Copy link

codecov bot commented Dec 17, 2018

Codecov Report

Merging #675 into master will decrease coverage by 0.04%.
The diff coverage is 1.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #675      +/-   ##
==========================================
- Coverage   11.13%   11.09%   -0.05%     
==========================================
  Files         252      252              
  Lines       22941    23034      +93     
  Branches     5794     5807      +13     
==========================================
+ Hits         2554     2555       +1     
- Misses      18856    18946      +90     
- Partials     1531     1533       +2     
Impacted Files Coverage Δ
rwengine/src/audio/alCheck.cpp 0.00% <ø> (ø)
rwengine/src/engine/GameState.hpp 0.00% <0.00%> (ø)
rwengine/src/script/modules/GTA3ModuleImpl.inl 0.00% <0.00%> (ø)
rwgame/HUDDrawer.cpp 0.00% <0.00%> (ø)
rwgame/HUDDrawer.hpp 0.00% <0.00%> (ø)
rwgame/RWGame.cpp 0.00% <0.00%> (ø)
rwengine/src/engine/GameState.cpp 3.12% <1.78%> (-2.44%) ⬇️
rwengine/src/objects/PickupObject.cpp 1.87% <14.28%> (+0.02%) ⬆️
rwengine/src/audio/SoundManager.cpp 14.89% <0.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a43d241...9f65c3b. Read the comment docs.

const std::array<int32_t, 4>& modelsToKill,
const bool headshot) {
// TODO: Document why
if (gxtEntry != "PAGE_00") {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 2 missions (Trial By Fire, Uzi Money) that use init_rampage opcode for their own purposes. They pass custom onscreen message, and there is a check if message isn't default then it's special mission rampage initialization, so don't increment rampagesPassed stat, because that's not a real rampage.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know, thank you - going to document that appropriately.
Nice to still see you around!

endif()

if(CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang")
if(CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang" AND CMAKE_TARGET STREQUAL "Xcode")
Copy link
Contributor

@madebr madebr Dec 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this (still) work?

ORWSRC=# paste path to your source here
mkdir /tmp/orwbin
cd /tmp/orwbin
CC=$(xcodebuild -find clang) CXX=$(xcodebuild -find clang++) cmake "$ORWSRC" "-GUnix Makefiles"
make -j9

uint32_t baseBrief;
};

class Rampage {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Rampage should get its own file.

@christoph-heiss christoph-heiss marked this pull request as draft May 11, 2020 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants