Updated from upstream #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since sidekiq/sidekiq#4804 sidekiq requires to be configured explicitly with a rack session.
`Redis#exists(key)` will return an Integer in redis-rb 4.3. `exists?` returns a boolean, you should use it instead. To opt-in to the new behavior now you can set Redis.exists_returns_integer = true. To disable this message and keep the current (boolean) behaviour of 'exists' you can set `Redis.exists_returns_integer = false`, but this option will be removed in 5.0.
Use ERB::Util.url_encode instead of deprecated URI.escape (#333) Add more rubies to test matrix
It appears that rufus-scheduler version 3.3.3 [uses the Rails timezone](jmettraux/rufus-scheduler@dc9e9df) if Rails is detected. [This commit](4b7eb81) bumps the version of rufus-scheduler, allowing it to upgrade to 3.3.x, which includes the change. This change modifies the README regarding cron syntax, to indicate that the current version of sidekiq_scheduler does use the Rails timezone when parsing cron statements.
This new version includes updates to ruby version plus some documentation updates and updates to some internals about sidekiq
Co-Authored-By: Jason Lee <huacnlee@users.noreply.github.com>
This reverts commit 24780e3.
Commit 07b9380 moved the styles to a separate file and mount like the rest of the Sidekiq assets. It looks like the CSS file does not have its path properly set up. The CSS path has been adjusted so that it loads properly now.
The CSS that would run for light-mode users is identical to dark mode's styles. This adjusts the default styles to at least match closer to the rest of Sidekiq's UI for the default theme.
This version includes: - Docs improvements - UI improvement switching from a table to list groups - Use POST requests to prevent CSRF - Brings back redis deprecation warning which will only be fixed in sidekiq-scheduler v4 - Add support for redis-rb >= 4.3
Context: redis/redis-rb#1059 The following is deprecated ```ruby redis.pipelined do redis.get(key) end ``` And should be rewritten as: ```ruby redis.pipelined do |pipeline| pipeline.get(key) end ``` Functionally it makes no difference.
End of life of ruby 2.4 was in March 31, 2020
Prevents introduction of breaking changes at patch or minor version level Close #477
It seems that `tilt` is for `sinatra`. 0313e5b#r14982005 I assume this was needed when the Sidekiq UI depended on `sinatra`, but that has not depended on it since sidekiq/sidekiq#3075. So I think we don't need it now. Let's remove it.
Changes disabled list item background color to better visualize disabled jobs.
LIghter disabled color.
Better option - just dim the text.
Figured we may as well get the ball rolling. This removes checks for older Sidekiq versions leaving support for only Sidekiq 7.3 which still has a level of support.
* Sidekiq 8 compatibility * Change sidekiq dependency to < 9 * Fix unsupported command issue * Updated CHANGELOG.md
- Copied/Moved existing view and stylesheet separately and load them accordingly if the Sidekiq version if 7.3. - Implemented new view and stylesheet using Sidekiq 8's variables and classes where applicable while providing the gem's own styles. I tried to make the resulting page close enough to the existing ui. - Renamed a couple web helpers just to be 110% sure we won't collide with anything.
This check isn't necessary anymore for v6 — people migrating from v4 to v5 need to see this error, but from v5 to v6, it doesn't make sense to run this check since in theory users won't have the sidekiq scheduler configs at the root level anymore. It could be that someone is migrating from v4 to v6, but then, it's on them to take this risk instead of upgrading 1 major version at time. Closes #469
See: sidekiq/sidekiq@cf7a879 ``` Original Error: NoMethodError vendor/bundle/ruby/3.3.0/gems/sidekiq-scheduler-6.0.0/lib/sidekiq-scheduler/extensions/web.rb:4:in `<main>': undefined method `configure' for class Sidekiq::Web (NoMethodError) Sidekiq::Web.configure do |cfg| ^^^^^^^^^^ from sidekiq-scheduler-6.0.0/lib/sidekiq-scheduler/web.rb:59:in `require_relative' from sidekiq-scheduler-6.0.0/lib/sidekiq-scheduler/web.rb:59:in `<main>' ``` This fixes for Sidekiq::Web < v7.3.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.