Fix for Convex SIMD traceback logic#76
Merged
rvaser merged 1 commit intorvaser:masterfrom Sep 21, 2025
Merged
Conversation
Owner
|
You are correct, thank you for pointing this out! |
rvaser
force-pushed
the
simd_gap_fix
branch
from
f8f56fb to
93df265
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the SIMD traceback logic, the
extend_leftlogic exits when the gap extension stops in either the E matrix or the Q matrix. This is incorrect, since we should only expect to be tracing back one type of gap or the other. The correct exit condition is when the gap extension stops in both the E matrix and the Q matrix. Compare to the same logic in the SISD implementation.Fixes #75