fix(esp32): use runtime node_id from NVS in outgoing packets#232
Open
melodykke wants to merge 2 commits intoruvnet:mainfrom
Open
fix(esp32): use runtime node_id from NVS in outgoing packets#232melodykke wants to merge 2 commits intoruvnet:mainfrom
melodykke wants to merge 2 commits intoruvnet:mainfrom
Conversation
- 为 Rust sensing server 增加空间布局配置入口，支持加载节点位置与语义区域定义，并扩展空间融合解释输出。 - 在 Docker 镜像中打包 config 目录，确保部署后可直接读取 spatial-layout.json。 - 修正 ESP32 显示界面中的节点编号来源，改为使用运行时 NVS 配置而非编译期常量。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix an ESP32 firmware issue where outgoing packets could use the compile-time node ID instead of the runtime node ID loaded from NVS.
In multi-node setups, this could cause a provisioned board to still appear with the wrong
node_idon the receiver side.Root Cause
Some packet serialization paths were still using
CONFIG_CSI_NODE_IDinstead ofg_nvs_config.node_id.That meant NVS provisioning could succeed while transmitted packets still carried the compile-time default.
Changes
Use
g_nvs_config.node_idconsistently in outgoing packet paths.Validation
Tested with a real ESP32-S3 setup.
node_id=2via NVSnode_id=2correctlyImpact
This makes runtime node provisioning behave correctly for multi-node deployments.