Skip to content

WIP: Adding lenient parsing#63

Draft
vagetman wants to merge 4 commits intorutgersc:masterfrom
vagetman:vadimfix
Draft

WIP: Adding lenient parsing#63
vagetman wants to merge 4 commits intorutgersc:masterfrom
vagetman:vadimfix

Conversation

@vagetman
Copy link
Contributor

@sdroege how does this approach sound to you?

@sdroege
Copy link
Collaborator

sdroege commented Feb 14, 2023

I would either make that the normal behaviour, or make it a runtime parameter. Using a cargo feature for this sounds potentially problematic and surprising because it would be enabled once at least one crate in your dependency tree uses it.

@vagetman
Copy link
Contributor Author

I would either make that the normal behaviour, or make it a runtime parameter. Using a cargo feature for this sounds potentially problematic and surprising because it would be enabled once at least one crate in your dependency tree uses it.

Hm... a runtime parameter to an app would mean another methods or additional parameters to existing functions (the latter is worse because it'd break dependencies and we would have to cut another version)

@sdroege
Copy link
Collaborator

sdroege commented Feb 15, 2023

I think I'd simply make it the default and only behaviour as long as it's for things like this where it's basically impossible for it to cause misbehaviour.

@vagetman
Copy link
Contributor Author

If I'm hearing you right you're suggesting to ingest manifests as is but won't render wrong attributes back if they shouldn't be there in the first place (aka not by the standard). Is it correct summary?

@sdroege
Copy link
Collaborator

sdroege commented Feb 15, 2023

Yes, unless those wrong attributes are specifically added to other_attributes or similar. That way we can parse more things but at least won't produce garbage unless the user explicitly asks for it.

@sdroege
Copy link
Collaborator

sdroege commented Apr 13, 2023

How should we proceed here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants