feat: v2.0.0-beta.1 - extract encodings to rfb-encodings crate #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dustinmcafee
commented
Oct 23, 2025
dustinmcafee
commented
- Extract all encoding implementations to separate rfb-encodings crate
- Maintain full backwards compatibility through re-exports
- Use published rfb-encodings 0.1.2 from crates.io
- Benefits: reusable encodings, cleaner architecture, better discoverability
- Extract all encoding implementations to separate rfb-encodings crate - Maintain full backwards compatibility through re-exports - Use published rfb-encodings 0.1.2 from crates.io - Benefits: reusable encodings, cleaner architecture, better discoverability
Updated rfb-encodings dependency from 0.1 to 0.1.3 to fix critical build failure when using turbojpeg feature without debug-logging feature.
- Added references to rfb-encodings throughout README, TECHNICAL, and CONTRIBUTING - Updated architecture diagrams to show separation between rustvncserver and rfb-encodings - Clarified that rfb-encodings provides encoding implementations for servers - Updated version examples to 2.0 - Bumped version to 2.0.0-beta.4
Remove duplicate code and improve maintainability: - Updated rfb-encodings dependency from 0.1.3 to 0.1.5 - Removed duplicate encoding constants (now imported from rfb-encodings) - Deleted duplicate src/jpeg/ module (now using TurboJPEG from rfb-encodings) - Code reduction: ~220 lines of duplicate code eliminated Add comprehensive TurboJPEG documentation and licensing information: - Added TurboJPEG installation instructions for all platforms - Updated NOTICE file with complete libjpeg-turbo attribution - Documented BSD-3-Clause, IJG, and zlib license components - Clarified that libjpeg-turbo is NOT distributed with this server
dustinmcafee
force-pushed
the
v2.0.0-beta
branch
from
f084e5b to
deab6ea
Compare
dustinmcafee
added a commit
that referenced
this pull request
Oct 27, 2025
feat: v2.0.0-beta.1 - extract encodings to rfb-encodings crate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.