Splits of modules into smaller files#41
Open
Hecatron wants to merge 18 commits intorustne-kretser:masterfrom
Open
Splits of modules into smaller files#41Hecatron wants to merge 18 commits intorustne-kretser:masterfrom
Hecatron wants to merge 18 commits intorustne-kretser:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suspect this probably won't go through as is.
But what I've done here is split the modules up into sub-directories with smaller files inside on a mostly struct boundary.
The module namespace should be the same as before so all the tests and examples still work fine.
What I'm aiming for is designing my own cli that can be used on an embedded device or desktop terminal.
Something similar to the serial interfaces on cisco or fortigate devices where you can auto complete or get hints / options by hitting tab
The source files are a bit on the big side though for me to work out where everything is located.
Since I'm a bit new to rust coming from other languages
I'm not sure if separating things out this way is a proper rust way of doing things, or if it's just a question of code style
but I figured I'd see about getting some feedback to see if this is a good or bad idea.