Closed
Conversation
- Polling the Executor is safe if the Executor is static. However, adding a static lifetime to self when polling makes the borrow checker unhappy. By adding a wrapper struct for the Executor that holds a static mutable reference, we can poll safely from the wrapper.
- The priority queue sender holds static reference to queue, and is therefor unsafe. It is up to the caller to ensure a static lifetime for the queue.
a2a5920 to
1f8cda8
Compare
Collaborator
Author
|
Continued in #18 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The priority queue used by the executor and timer is only safe if it is static. Because of this, functions such as polling tasks are now unsafe. By wrapping the executor in a struct that holds a static reference, we can safely call the unsafe functions from the wrapper: