Misc fixes of PR #24

[cathay4t]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @cathay4t, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a series of miscellaneous fixes and internal refactorings within the eeprom module. The primary goal is to enhance code quality, consistency, and maintainability by updating Netlink attribute handling to leverage netlink_packet_core and by applying widespread formatting adjustments for improved readability. The changes do not alter the external behavior or core functionality of the ethtool module EEPROM operations, but rather refine their underlying implementation.

Highlights

• Dependency Refactoring: The src/eeprom/attr.rs file has been refactored to use utilities from netlink_packet_core directly for Netlink Attribute (NLA) handling, replacing netlink_packet_utils, anyhow::Context, and byteorder. This streamlines dependency management and aligns with core Netlink packet processing.
• Code Style and Readability Improvements: Extensive formatting changes have been applied across multiple files, including src/eeprom/get.rs, src/eeprom/handle.rs, src/message.rs, src/lib.rs, and src/handle.rs. These changes primarily involve consistent line breaks and trailing commas in function signatures, struct initializations, and import statements, enhancing overall code readability and maintainability.
• NLA Emission Consistency: The emission of u32 values for Offset and Length attributes within src/eeprom/attr.rs has been updated to utilize the emit_u32 function from netlink_packet_core, ensuring a consistent approach to NLA data serialization following the dependency refactoring.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request primarily consists of code formatting changes and dependency updates. While reviewing, I identified a critical pre-existing issue in src/eeprom/attr.rs where the Parseable implementation for EthtoolModuleEEPROMAttr was incomplete, causing several attributes to be parsed incorrectly. I've provided a detailed comment and a code suggestion to fix this bug. The other changes are stylistic and improve code consistency.

[gemini-code-assist]

The Parseable implementation for EthtoolModuleEEPROMAttr is incomplete. It's missing handlers for ETHTOOL_A_MODULE_EEPROM_OFFSET, ETHTOOL_A_MODULE_EEPROM_LENGTH, ETHTOOL_A_MODULE_EEPROM_PAGE, ETHTOOL_A_MODULE_EEPROM_BANK, and ETHTOOL_A_MODULE_EEPROM_I2C_ADDRESS. This will cause these attributes to be incorrectly parsed as EthtoolModuleEEPROMAttr::Other when they are present in a netlink message from the kernel. This is a critical issue as it prevents correct parsing of ETHTOOL_MSG_MODULE_EEPROM_GET_REPLY messages.

            ETHTOOL_A_MODULE_EEPROM_OFFSET => Self::Offset(
                netlink_packet_core::parse_u32(payload)
                    .context("invalid ETHTOOL_A_MODULE_EEPROM_OFFSET value")?,
            ),
            ETHTOOL_A_MODULE_EEPROM_LENGTH => Self::Length(
                netlink_packet_core::parse_u32(payload)
                    .context("invalid ETHTOOL_A_MODULE_EEPROM_LENGTH value")?,
            ),
            ETHTOOL_A_MODULE_EEPROM_PAGE => {
                if payload.len() != 1 {
                    return Err(DecodeError::from(
                        "invalid ETHTOOL_A_MODULE_EEPROM_PAGE value: length is not 1",
                    ));
                }
                Self::Page(payload[0])
            }
            ETHTOOL_A_MODULE_EEPROM_BANK => {
                if payload.len() != 1 {
                    return Err(DecodeError::from(
                        "invalid ETHTOOL_A_MODULE_EEPROM_BANK value: length is not 1",
                    ));
                }
                Self::Bank(payload[0])
            }
            ETHTOOL_A_MODULE_EEPROM_I2C_ADDRESS => {
                if payload.len() != 1 {
                    return Err(DecodeError::from(
                        "invalid ETHTOOL_A_MODULE_EEPROM_I2C_ADDRESS value: length is not 1",
                    ));
                }
                Self::I2CAddress(payload[0])
            }
            ETHTOOL_A_MODULE_EEPROM_DATA => Self::Data(Vec::from(payload)),
            kind => Self::Other(DefaultNla::parse(buf).context(format!(
                "invalid ethtool module eeprom NLA kind {kind}"
            ))?),
        })