Rollup of 4 pull requests #150115

JonathanBrouwer · 2025-12-17T22:31:23Z

Successful merges:

Tidying up tests/ui/issues 14 tests [5/N] #149922 (Tidying up tests/ui/issues 14 tests [5/N])
Port #[rustc_no_implicit_autorefs], #[rustc_lint_opt_ty], and #[rustc_lint_query_instability] attributes to be parsed #150095 (Port #[rustc_no_implicit_autorefs], #[rustc_lint_opt_ty], and #[rustc_lint_query_instability] attributes to be parsed)
[rustdoc] Fix invalid handling of field followed by negated macro call #150099 ([rustdoc] Fix invalid handling of field followed by negated macro call)
Update tracking issue for PinCoerceUnsized #150113 (Update tracking issue for PinCoerceUnsized)

r? @ghost
@rustbot modify labels: rollup

Tidying up tests/ui/issues 14 tests [5/N] > [!NOTE] > Intermediate commits are intended to help review, but will be squashed add comment commit prior to merge. part of rust-lang#133895 move `tests/ui/inherent-impls-overlap-check` to `tests/ui/duplicate/inherent-impls-overlap-check`. r? Kivooeo

…butes, r=JonathanBrouwer Port `#[rustc_no_implicit_autorefs]`, `#[rustc_lint_opt_ty]`, and `#[rustc_lint_query_instability]` attributes to be parsed This PR ports three simple internal rustc attributes to be parsed in a single PR to avoid having to resolve multiple rebase confilicts r? ``@JonathanBrouwer``

…otamofek [rustdoc] Fix invalid handling of field followed by negated macro call This is the bug uncovered in rust-lang#150022. Once fixed Ill rebuild all compiler docs and see if we can enable the option for compiler docs. =D It's a weird case where we extracted some tokens out of the iterator and then, when checking next items (from this iterator), it didn't find the `:` token, and therefore badly assumed the token kind. The solution I came up with is to instead not extract tokens from the iterator and to count how many tokens are in the current path. So when iterate over the items, instead of having a mix of extracted tokens and tokens still inside the iterator, we now only iterate over the iterator. The biggest change here is that `get_full_ident_path` will return an option instead of a `Vec`, and if it's contains `:` (one, not two), then it will return `None` and the `:` will be handled like any token and not like a path (which is more correct imo). r? `@yotamofek`

…112, r=jackh726 Update tracking issue for PinCoerceUnsized This uses the newly created tracking issue rust-lang#150112. Please see rust-lang#68015 (comment) for motivation. r? ``@jackh726``

JonathanBrouwer · 2025-12-17T22:31:37Z

@bors r+ rollup=never p=5

bors · 2025-12-17T22:31:40Z

📌 Commit 4ea2467 has been approved by JonathanBrouwer

It is now in the queue for this repository.

bors · 2025-12-17T23:31:36Z

⌛ Testing commit 4ea2467 with merge 686f9ce...

bors · 2025-12-18T02:57:17Z

☀️ Test successful - checks-actions
Approved by: JonathanBrouwer
Pushing 686f9ce to main...

rust-timer · 2025-12-18T02:58:28Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#149922	Tidying up tests/ui/issues 14 tests [5/N]	`e5b68e37e8b4853f2b36fcd79a9b256a0c54eacd` (link)
#150095	Port `#[rustc_no_implicit_autorefs]`, `#[rustc_lint_opt_ty]…	`b4857b101c4e4cffe58645c9c1e0596c5bdb1162` (link)
#150099	[rustdoc] Fix invalid handling of field followed by negated…	`a4b60a95a62f56c235be4703e6a7600965c662c2` (link)
#150113	Update tracking issue for PinCoerceUnsized	`9a096b7cc0190ba5325b48be94d3bd06fa593a1e` (link)

previous master: f794a08738

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-12-18T03:00:05Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing f794a08 (parent) -> 686f9ce (this PR)

Test differences

Show 355 test diffs

Stage 0

errors::verify_passes_abi_invalid_attribute_66: [missing] -> pass (J0)
errors::verify_passes_abi_ne_65: [missing] -> pass (J0)
errors::verify_passes_attr_application_struct_78: [missing] -> pass (J0)
errors::verify_passes_attr_application_struct_enum_union_80: [missing] -> pass (J0)
errors::verify_passes_attr_application_struct_enum_union_81: pass -> [missing] (J0)
errors::verify_passes_const_stable_not_stable_94: pass -> [missing] (J0)
errors::verify_passes_custom_mir_incompatible_dialect_and_phase_112: [missing] -> pass (J0)
errors::verify_passes_custom_mir_incompatible_dialect_and_phase_113: pass -> [missing] (J0)
errors::verify_passes_deprecated_attribute_83: pass -> [missing] (J0)
errors::verify_passes_duplicate_diagnostic_item_in_crate_57: [missing] -> pass (J0)
errors::verify_passes_duplicate_diagnostic_item_in_crate_58: pass -> [missing] (J0)
errors::verify_passes_extern_main_71: [missing] -> pass (J0)
errors::verify_passes_extern_main_72: pass -> [missing] (J0)
errors::verify_passes_feature_previously_declared_69: [missing] -> pass (J0)
errors::verify_passes_feature_stable_twice_68: [missing] -> pass (J0)
errors::verify_passes_incorrect_crate_type_74: pass -> [missing] (J0)
errors::verify_passes_ineffective_unstable_impl_97: [missing] -> pass (J0)
errors::verify_passes_inline_ignored_for_exported_75: [missing] -> pass (J0)
errors::verify_passes_lang_item_fn_with_target_feature_54: [missing] -> pass (J0)
errors::verify_passes_lang_item_on_incorrect_target_56: pass -> [missing] (J0)
errors::verify_passes_layout_abi_59: pass -> [missing] (J0)
errors::verify_passes_layout_align_59: [missing] -> pass (J0)
errors::verify_passes_layout_of_63: pass -> [missing] (J0)
errors::verify_passes_missing_const_stab_attr_87: [missing] -> pass (J0)
errors::verify_passes_missing_lang_item_52: [missing] -> pass (J0)
errors::verify_passes_missing_stability_attr_87: pass -> [missing] (J0)
errors::verify_passes_object_lifetime_err_77: pass -> [missing] (J0)
errors::verify_passes_repr_align_should_be_align_109: [missing] -> pass (J0)
errors::verify_passes_rustc_lint_opt_deny_field_access_46: [missing] -> pass (J0)
errors::verify_passes_rustc_lint_opt_ty_46: pass -> [missing] (J0)
errors::verify_passes_unexportable_adt_with_private_fields_108: [missing] -> pass (J0)
errors::verify_passes_unexportable_generic_fn_103: [missing] -> pass (J0)
errors::verify_passes_unexportable_priv_item_107: [missing] -> pass (J0)
errors::verify_passes_unexportable_type_repr_105: [missing] -> pass (J0)
errors::verify_passes_unknown_external_lang_item_49: [missing] -> pass (J0)
errors::verify_passes_unknown_feature_alias_90: pass -> [missing] (J0)
errors::verify_passes_unknown_lang_item_56: [missing] -> pass (J0)
errors::verify_passes_unknown_lang_item_57: pass -> [missing] (J0)
errors::verify_passes_unnecessary_partial_stable_feature_96: [missing] -> pass (J0)
errors::verify_passes_unnecessary_stable_feature_95: [missing] -> pass (J0)
errors::verify_passes_unnecessary_stable_feature_96: pass -> [missing] (J0)
errors::verify_passes_unsupported_attributes_in_where_102: pass -> [missing] (J0)
errors::verify_passes_useless_assignment_74: [missing] -> pass (J0)
errors::verify_passes_useless_stability_83: [missing] -> pass (J0)

Stage 1

[ui] tests/ui/autoref-autoderef/autoderef-arc-boxed-closure-call.rs: [missing] -> pass (J0)
[ui] tests/ui/duplicate/inherent-impls-overlap-check/no-overlap.rs: [missing] -> pass (J0)
[ui] tests/ui/hashmap/hashmap-path-key.rs: [missing] -> pass (J0)
[ui] tests/ui/issues/issue-19097.rs: pass -> [missing] (J0)
[ui] tests/ui/issues/issue-27268.rs: pass -> [missing] (J0)
[ui] tests/ui/match/match-usize-min-max-pattern.rs: [missing] -> pass (J0)
errors::verify_passes_abi_ne_65: [missing] -> pass (J1)
errors::verify_passes_abi_of_64: [missing] -> pass (J1)
errors::verify_passes_abi_of_65: pass -> [missing] (J1)
errors::verify_passes_attr_application_enum_77: [missing] -> pass (J1)
errors::verify_passes_attr_application_struct_79: pass -> [missing] (J1)
errors::verify_passes_attr_application_struct_enum_union_81: pass -> [missing] (J1)
errors::verify_passes_attr_crate_level_98: [missing] -> pass (J1)
errors::verify_passes_cannot_stabilize_deprecated_85: pass -> [missing] (J1)
errors::verify_passes_collapse_debuginfo_47: [missing] -> pass (J1)
errors::verify_passes_const_stable_not_stable_93: [missing] -> pass (J1)
errors::verify_passes_custom_mir_incompatible_dialect_and_phase_112: [missing] -> pass (J1)
errors::verify_passes_custom_mir_phase_requires_dialect_111: [missing] -> pass (J1)
errors::verify_passes_deprecated_attribute_82: [missing] -> pass (J1)
errors::verify_passes_deprecated_attribute_83: pass -> [missing] (J1)
errors::verify_passes_duplicate_feature_err_91: [missing] -> pass (J1)
errors::verify_passes_duplicate_feature_err_92: pass -> [missing] (J1)
errors::verify_passes_eii_impl_not_function_113: [missing] -> pass (J1)
errors::verify_passes_eii_impl_not_function_114: pass -> [missing] (J1)
errors::verify_passes_extern_main_72: pass -> [missing] (J1)
errors::verify_passes_implied_feature_not_exist_90: [missing] -> pass (J1)
errors::verify_passes_incorrect_target_73: pass -> [missing] (J1)
errors::verify_passes_inline_ignored_for_exported_76: pass -> [missing] (J1)
errors::verify_passes_lang_item_on_incorrect_target_55: [missing] -> pass (J1)
errors::verify_passes_lang_item_on_incorrect_target_56: pass -> [missing] (J1)
errors::verify_passes_layout_homogeneous_aggregate_62: pass -> [missing] (J1)
errors::verify_passes_layout_of_62: [missing] -> pass (J1)
errors::verify_passes_missing_const_err_93: pass -> [missing] (J1)
errors::verify_passes_missing_lang_item_52: [missing] -> pass (J1)
errors::verify_passes_multiple_rustc_main_71: pass -> [missing] (J1)
errors::verify_passes_repr_align_should_be_align_110: pass -> [missing] (J1)
errors::verify_passes_repr_align_should_be_align_static_111: pass -> [missing] (J1)
errors::verify_passes_rustc_lint_opt_deny_field_access_47: pass -> [missing] (J1)
errors::verify_passes_unexportable_fn_abi_105: pass -> [missing] (J1)
errors::verify_passes_unexportable_item_102: [missing] -> pass (J1)
errors::verify_passes_unexportable_priv_item_107: [missing] -> pass (J1)
errors::verify_passes_unexportable_priv_item_108: pass -> [missing] (J1)
errors::verify_passes_unknown_feature_alias_89: [missing] -> pass (J1)
errors::verify_passes_unknown_lang_item_56: [missing] -> pass (J1)
errors::verify_passes_unrecognized_argument_68: pass -> [missing] (J1)
errors::verify_passes_unsupported_attributes_in_where_102: pass -> [missing] (J1)
errors::verify_passes_useless_stability_84: pass -> [missing] (J1)

Stage 2

[ui] tests/ui/consts/const-closure-fn-trait-object.rs: [missing] -> pass (J2)
[ui] tests/ui/duplicate/inherent-impls-overlap-check/overlap.rs: [missing] -> pass (J2)
[ui] tests/ui/inherent-impls-overlap-check/no-overlap.rs: pass -> [missing] (J2)
[ui] tests/ui/issues/issue-21891.rs: pass -> [missing] (J2)
[ui] tests/ui/issues/issue-24161.rs: pass -> [missing] (J2)
[ui] tests/ui/issues/issue-26646.rs: pass -> [missing] (J2)
[ui] tests/ui/issues/issue-38987.rs: pass -> [missing] (J2)
[ui] tests/ui/numbers-arithmetic/i128-min-literal-parses.rs: [missing] -> pass (J2)
[ui] tests/ui/str/raw-string-literal-unescaped-unicode.rs: [missing] -> pass (J2)

(and 252 additional test diffs)

Additionally, 3 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 686f9cefc37c5bdec069a75357f0277b390657ca --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-apple-various: 4931.5s -> 3287.8s (-33.3%)
pr-check-1: 2010.3s -> 1732.3s (-13.8%)
dist-i686-mingw: 9526.1s -> 10556.4s (+10.8%)
dist-i686-msvc: 8621.9s -> 7769.0s (-9.9%)
dist-aarch64-msvc: 5643.5s -> 6196.3s (+9.8%)
aarch64-apple: 10826.9s -> 11875.1s (+9.7%)
aarch64-msvc-2: 5799.5s -> 6358.2s (+9.6%)
dist-loongarch64-linux: 5369.4s -> 5739.6s (+6.9%)
i686-gnu-1: 8342.2s -> 7788.9s (-6.6%)
aarch64-gnu-llvm-20-2: 3144.0s -> 3340.6s (+6.3%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-12-18T03:38:17Z

Finished benchmarking commit (686f9ce): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.1%	[0.1%, 0.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.4%	[-0.5%, -0.4%]	2
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -1.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.6%	[-2.5%, -0.7%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.6%	[-2.5%, -0.7%]	2

Cycles

Results (primary 2.1%, secondary -2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.1%	[2.1%, 2.1%]	1
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.2%	[-5.1%, -3.3%]	2
All ❌✅ (primary)	2.1%	[2.1%, 2.1%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 481.694s -> 481.939s (0.05%)
Artifact size: 390.59 MiB -> 390.59 MiB (-0.00%)

reddevilmidzy and others added 13 commits December 13, 2025 00:53

move tests

eb8da2f

cleaned up some tests

1f406db

Move inherent-impls-overlap-check to duplicate's subdirectory

bf92214

Fix invalid handling of field followed by negated macro call

851f169

Port #[rustc_no_implicit_autorefs] to attribute parser

bbda675

Port #[rustc_lint_opt_ty] to parsed attribute

81d2036

Port #[rustc_lint_query_instability] to parsed attribute

96e453d

Update tracking issue for PinCoerceUnsized

78f52c1

Improve code by using iterator::sum instead of looping

2114b21

Rollup merge of rust-lang#150113 - Darksonn:pin-coerce-unsized-to-150…

4ea2467

…112, r=jackh726 Update tracking issue for PinCoerceUnsized This uses the newly created tracking issue rust-lang#150112. Please see rust-lang#68015 (comment) for motivation. r? ``@jackh726``

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 17, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 18, 2025

bors merged commit 686f9ce into rust-lang:main Dec 18, 2025
12 checks passed

rustbot added this to the 1.94.0 milestone Dec 18, 2025

This was referenced Dec 18, 2025

Implement coercions between &pin (mut|const) T and &(mut) T when T: Unpin #149130

Open

Make PinCoerceUnsized require Deref #149218

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Rollup of 4 pull requests #150115

Rollup of 4 pull requests #150115

Uh oh!

JonathanBrouwer commented Dec 17, 2025 •

edited by rustbot

Loading

Uh oh!

JonathanBrouwer commented Dec 17, 2025

Uh oh!

bors commented Dec 17, 2025

Uh oh!

bors commented Dec 17, 2025

Uh oh!

bors commented Dec 18, 2025

Uh oh!

Uh oh!

rust-timer commented Dec 18, 2025

Uh oh!

github-actions bot commented Dec 18, 2025

Stage 0

Stage 1

Stage 2

Uh oh!

rust-timer commented Dec 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Rollup of 4 pull requests #150115

Rollup of 4 pull requests #150115

Uh oh!

Conversation

JonathanBrouwer commented Dec 17, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented Dec 17, 2025

Uh oh!

bors commented Dec 17, 2025

Uh oh!

bors commented Dec 17, 2025

Uh oh!

bors commented Dec 18, 2025

Uh oh!

Uh oh!

rust-timer commented Dec 18, 2025

Uh oh!

github-actions bot commented Dec 18, 2025

Test differences

Stage 0

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Dec 18, 2025

Overall result: ❌✅ regressions and improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

JonathanBrouwer commented Dec 17, 2025 •

edited by rustbot

Loading