Support recursive delegation #150024
Support recursive delegation #150024
Conversation
rustbot
added
S-waiting-on-review
petrochenkov
added
S-waiting-on-author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
compiler/rustc_middle/src/ty/mod.rs
Outdated
|
|
||
| /// Information about functions signatures for delegation items expansion | ||
| pub delegation_fn_sigs: LocalDefIdMap<DelegationFnSig>, | ||
| // NodeIds for delegation signature resolution |
There was a problem hiding this comment.
This comment repeats the field name and doesn't say anything about what these ids mean and why they are necessary when we already have item ids and delegation ids.
There was a problem hiding this comment.
Added more descriptive comment with a reference to a github comment with deeper explanation.
| let sig_id = self.get_delegation_sig_id(item_id, delegation.id, span, is_in_trait_impl); | ||
|
|
||
| let sig_id = self.get_delegation_sig_id( | ||
| self.get_delegation_sig_node_id(&self.local_def_id(item_id)), |
There was a problem hiding this comment.
What is the difference between "sig id" and "sig node id"?
It's hard to understand what's going on without some consistent naming and comments telling what is what.
There was a problem hiding this comment.
As get_delegation_sig_node_id method was removed, and with a comment on delegation_sig_resolution_nodes and comments in get_delegation_sig_id method I believe it should be clear now.
petrochenkov
added
S-waiting-on-author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
3 participants
This PR adds support for recursive delegations and is a part of the delegation feature #118212.
r? @petrochenkov