Generate macro expansion for rust compiler crates docs #150022
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
|
Failed to set assignee to
|
Member
Author
|
Huuuum. Interesting. r? kobzol |
Collaborator
|
|
Kobzol
approved these changes
Dec 15, 2025
Member
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Dec 16, 2025
…on, r=Kobzol Generate macro expansion for rust compiler crates docs This enables the `--generate-macro-expansion` rustdoc flag, generating possibility to expand macros directly in source code pages (rust-lang#137229). Needed this new feature when I was working on rust-lang#149919 and I thought "why not enable it by default?". So here we go. Not too sure who to r? here so: r? `@kobzol`
bors
added a commit
that referenced
this pull request
Dec 16, 2025
Rollup of 14 pull requests Successful merges: - #148756 (Warn on codegen attributes on required trait methods) - #148790 (Add new Tier-3 target: riscv64im-unknown-none-elf) - #149271 (feat: dlopen Enzyme) - #149459 (std: sys: fs: uefi: Implement set_times and set_perm) - #149771 (bootstrap readme: make easy to read when editor wrapping is not enabled) - #149856 (Provide an extended framework for type visit, for use in rust-analyzer) - #149950 (Simplify how inline asm handles `MaybeUninit`) - #150014 (Metadata loader cleanups) - #150021 (document that mpmc channels deliver an item to (at most) one receiver) - #150022 (Generate macro expansion for rust compiler crates docs) - #150029 (Update books) - #150031 (assert impossible branch is impossible) - #150034 (do not add `I-prioritize` when `F-*` labels are present) - #150036 (Use the embeddable filename for coverage artifacts) r? `@ghost` `@rustbot` modify labels: rollup
Member
|
Possibly failed in rollup? #150039 (comment) @bors r- |
bors
added
S-waiting-on-author
Member
|
@bors try jobs=dist-x86_64-linux-alt |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Dec 16, 2025
Generate macro expansion for rust compiler crates docs try-job: dist-x86_64-linux-alt
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test for 0ac0f58 failed: CI. Failed jobs:
|
Member
Author
|
Was able to write a minified code to reproduce the bug: struct Bar {
bla: bool,
}
macro_rules! f {
() => {{ false }}
}
const X: Bar = Bar {
bla: !f!(),
};Just need to run it with |
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Dec 17, 2025
…otamofek [rustdoc] Fix invalid handling of field followed by negated macro call This is the bug uncovered in rust-lang#150022. Once fixed Ill rebuild all compiler docs and see if we can enable the option for compiler docs. =D It's a weird case where we extracted some tokens out of the iterator and then, when checking next items (from this iterator), it didn't find the `:` token, and therefore badly assumed the token kind. The solution I came up with is to instead not extract tokens from the iterator and to count how many tokens are in the current path. So when iterate over the items, instead of having a mix of extracted tokens and tokens still inside the iterator, we now only iterate over the iterator. The biggest change here is that `get_full_ident_path` will return an option instead of a `Vec`, and if it's contains `:` (one, not two), then it will return `None` and the `:` will be handled like any token and not like a path (which is more correct imo). r? `@yotamofek`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the
--generate-macro-expansionrustdoc flag, generating possibility to expand macros directly in source code pages (#137229).Needed this new feature when I was working on #149919 and I thought "why not enable it by default?". So here we go.
Not too sure who to r? here so:
r? @Kobzol