Skip to content

Stabilize extended_varargs_abi_support #116161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Nov 30, 2024
Merged

Stabilize extended_varargs_abi_support #116161

bors merged 1 commit into from
Nov 30, 2024

Conversation

@Soveu
Copy link
Contributor

@Soveu Soveu commented Sep 25, 2023 •
edited by jieyouxu
Loading

I think that is everything? If there is any documentation regarding extern and/or varargs to correct, let me know, some quick greps suggest that there might be none.

Tracking issue: #100189

@rustbot
Copy link
Collaborator

rustbot commented Sep 25, 2023

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 25, 2023
@Soveu Soveu mentioned this pull request Sep 25, 2023
Closed
3 tasks
Noratrieb
Noratrieb reviewed Sep 25, 2023
View reviewed changes
@Soveu
Copy link
Contributor Author

Soveu commented Sep 25, 2023

@rustbot label F-extended_varargs_abi_support

@rustbot rustbot added the F-extended_varargs_abi_support `#![feature(extended_varargs_abi_support)]` label Sep 25, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
kadiwa4
kadiwa4 reviewed Sep 25, 2023
View reviewed changes
compiler/rustc_feature/src/accepted.rs Outdated
(accepted, extended_key_value_attributes, "1.54.0", Some(78835), None),
/// Allows using `efiapi`, `aapcs`, `sysv64` and `win64` as calling
/// convention for functions with varargs.
(accepted, extended_varargs_abi_support, "1.65.0", Some(100189), None),
Copy link
Contributor

@kadiwa4 kadiwa4 Sep 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use CURRENT_RUSTC_VERSION instead of a version number here

@tgross35
Copy link
Contributor

tgross35 commented Oct 5, 2023

Tracking issue: #100189

@bors
Copy link
Collaborator

bors commented Oct 16, 2023

☔ The latest upstream changes (presumably #116550) made this pull request unmergeable. Please resolve the merge conflicts.

@nicholasbishop nicholasbishop mentioned this pull request Nov 4, 2023
Open
3 tasks
@Soveu
Copy link
Contributor Author

Soveu commented Nov 21, 2023

@wesleywiser

@bors
Copy link
Collaborator

bors commented Dec 11, 2023

☔ The latest upstream changes (presumably #118823) made this pull request unmergeable. Please resolve the merge conflicts.

@apiraino
Copy link
Contributor

apiraino commented Feb 22, 2024

r? compiler

@rustbot rustbot assigned Nadrieril and unassigned wesleywiser Feb 22, 2024
Skgland
Skgland reviewed Feb 22, 2024
View reviewed changes
@Nadrieril
Copy link
Member

Nadrieril commented Feb 22, 2024

I'm on vacation for a few days :)
r? compiler

@rustbot rustbot assigned cjgillot and unassigned Nadrieril Feb 22, 2024
@cjgillot cjgillot added I-lang-nominated Nominated for discussion during a lang team meeting. I-compiler-nominated Nominated for discussion during a compiler team meeting. labels Mar 3, 2024
@cjgillot
Copy link
Contributor

cjgillot commented Mar 3, 2024

Not completely sure which team should be nominated for stabilization, so labeling both in doubt.

@pnkfelix
Copy link
Contributor

pnkfelix commented Mar 7, 2024 •
edited
Loading

Just to add on to @cjgillot 's comment above: @wesleywiser and I could not remember earlier today whether T-lang wants to own FCP'ing changes like this that are restricted to extending the set of calling-conventions (i.e. the conv in extern "conv" fn foo(...)), which is largely a detail about what platforms one is interoperating with, and not about changing the expressiveness of the Rust language as a whole in the abstract.

(My own gut reaction is that T-compiler is a more natural owner for this than T-lang, but I wasn't certain and so it seems best to let the nomination stand and let the two teams duke it out.)

@apiraino
Copy link
Contributor

apiraino commented Mar 14, 2024

Removing the T-compiler nomination until after T-lang discussed this. Feel free to re-add T-compiler!

@rustbot label -I-compiler-nominated

@rustbot rustbot removed the I-compiler-nominated Nominated for discussion during a compiler team meeting. label Mar 14, 2024
@jieyouxu jieyouxu mentioned this pull request Nov 30, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 30, 2024
@bors
Auto merge of rust-lang#133658 - jieyouxu:rollup-rq7e0gk, r=jieyouxu
b980396 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#116161 (Stabilize `extended_varargs_abi_support`)
 - rust-lang#132750 ([AIX] handle libunwind native_libs)
 - rust-lang#133488 (tests: Add regression test for self referential structs with cow as last field)
 - rust-lang#133569 (Bump `ruzstd` to 0.7.3)
 - rust-lang#133585 (Do not call `extern_crate` on current trait on crate mismatch errors)
 - rust-lang#133587 (Fix target_feature handling in freg of LoongArch inline assembly)
 - rust-lang#133599 (Add `+forced-atomics` feature to esp32s2 no_std  target)
 - rust-lang#133620 (Simplify hir_typeck_pass_to_variadic_function)
 - rust-lang#133623 (Improve span handling in `parse_expr_bottom`.)
 - rust-lang#133625 (custom MIR: add doc comment for debuginfo)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 30, 2024
@bors
Auto merge of rust-lang#133658 - jieyouxu:rollup-rq7e0gk, r=jieyouxu
e93e096 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#116161 (Stabilize `extended_varargs_abi_support`)
 - rust-lang#132750 ([AIX] handle libunwind native_libs)
 - rust-lang#133488 (tests: Add regression test for self referential structs with cow as last field)
 - rust-lang#133569 (Bump `ruzstd` to 0.7.3)
 - rust-lang#133585 (Do not call `extern_crate` on current trait on crate mismatch errors)
 - rust-lang#133587 (Fix target_feature handling in freg of LoongArch inline assembly)
 - rust-lang#133599 (Add `+forced-atomics` feature to esp32s2 no_std  target)
 - rust-lang#133620 (Simplify hir_typeck_pass_to_variadic_function)
 - rust-lang#133623 (Improve span handling in `parse_expr_bottom`.)
 - rust-lang#133625 (custom MIR: add doc comment for debuginfo)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit dd99f11 into rust-lang:master Nov 30, 2024
6 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Nov 30, 2024
@HTGAzureX1212 HTGAzureX1212 mentioned this pull request Dec 4, 2024
Closed
2 tasks
@Ayush1325 Ayush1325 mentioned this pull request Dec 24, 2024
Draft
@chorman0773
Copy link
Contributor

chorman0773 commented Feb 12, 2025

This is in beta but not yet stable. It should probably be reverted as https://godbolt.org/z/fYzxa8xW5 compiles with this but probably ought not to, at least on targets like i686-pc-windows-msvc where the underlying abi of extern "system" is incompatible with varargs.

@chorman0773
Copy link
Contributor

chorman0773 commented Feb 12, 2025

@rustbot label +I-compiler-nominated +I-lang-nominated

Should this be reverted (and backported) to allow addressing whether extern "system" should allow varargs functions, and when?

@rustbot rustbot added I-compiler-nominated Nominated for discussion during a compiler team meeting. I-lang-nominated Nominated for discussion during a lang team meeting. labels Feb 12, 2025
@workingjubilee workingjubilee removed I-lang-nominated Nominated for discussion during a lang team meeting. I-compiler-nominated Nominated for discussion during a compiler team meeting. labels Feb 12, 2025
@workingjubilee
Copy link
Member

workingjubilee commented Feb 12, 2025

moving that discussion to a new issue.

@workingjubilee workingjubilee mentioned this pull request Feb 12, 2025
Closed
@chorman0773 chorman0773 mentioned this pull request Feb 12, 2025
Merged
@workingjubilee workingjubilee mentioned this pull request Feb 12, 2025
Merged
@RalfJung RalfJung mentioned this pull request Jul 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Noratrieb Noratrieb Noratrieb left review comments

+2 more reviewers

@Skgland Skgland Skgland left review comments

@kadiwa4 kadiwa4 kadiwa4 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@cjgillot cjgillot

Labels

F-extended_varargs_abi_support `#![feature(extended_varargs_abi_support)]` I-lang-easy-decision Issue: The decision needed by the team is conjectured to be easy; this does not imply nomination relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-lang Relevant to the language team

Projects

None yet

Milestone

1.85.0

Development

Successfully merging this pull request may close these issues.