feat: add serde support for ISO3166 2/3#19
Open
SandmeyerX wants to merge 1 commit intorust-iso:mainfrom
Open
Conversation
- Implement Serialize/Deserialize for ISO3166-2 and ISO3166-3 - Improve code by cargo fmt - Fix clippy warning - Add serde round-trip tests to ensure correctness
Contributor
|
These files are generated from scripts/iso3166_2.py, scripts/iso3166_3.py, and scripts/lib.py, so their formatting should not be modified directly to avoid future maintenance issues. Please update the corresponding generator scripts instead, run and test it , and then resubmit the PR. Thank you very much! |
Author
@zhangjiayin Got it! I'll get on that right away |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
cargo fmtcargo clippyno warningNote:
Run
cargo add rust_iso3166 -F serdeto enable the featureDirect deserialization of numeric codes is not currently supported
Close #13