Remove the use of bip324::serde in traffic with V2 wrapper#155
Merged
rustaceanrob merged 1 commit intorust-bitcoin:mainfrom Sep 4, 2025
Merged
Remove the use of bip324::serde in traffic with V2 wrapper#155rustaceanrob merged 1 commit intorust-bitcoin:mainfrom
rustaceanrob merged 1 commit intorust-bitcoin:mainfrom
Conversation
To prepare for removing `bitcoin` as a dependency, we can get a jump by removing the use of `bip324::serde` in the test suite. Understandable if it is too weird to depend on specific commits in the test suite, but throwing it up because it is not a horribly complicated change. Co-authored-by: Nick Johnson <nick@yonson.dev>
Collaborator
|
Lol I didn't even think about the actual dependency of the crate. ACK 9329bb2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #154 with some V2 wrappers.
I am kinda surprised this doesn't cause some dependency issues, but have a working theory. This patch pulls in a completely new
bitcoindependency for two reasons. First off, it has the versionv0.33.0-alpha.0so is a semantic versioning breaking change, but also, the git source vs. crates.io makes it a new dependency as well. I believe this means the types in the crates are incompatible. But it works out because the types being used (e.g.NetworkMessage,V2NetworkMessage) are not crossing the crate boundary betweentrafficandprotocol(good call by us). AndNetworkis re-export byprotocol, so also ok there.