Closed
Conversation
rustaceanrob
force-pushed
the
rust-bitcoin-dev-7-24
branch
2 times, most recently
from
02506c7 to
5d290c5
Compare
Collaborator
Author
|
Given an ACK I would just push this to the upstream under a new branch |
nyonson
reviewed
Jul 24, 2025
protocol/Cargo.toml
Outdated
| tokio = { version = "1", default-features = false, optional = true, features = ["io-util"] } | ||
| rand = { version = "0.8.0", default-features = false } | ||
| bitcoin = { version = "0.32.4", default-features = false } | ||
| bitcoin = { git = "https://github.com/rust-bitcoin/rust-bitcoin", default-features = false, rev = "bd450d7be31bb50b6bc33f2417bfb5f0b00191b0" } |
Collaborator
There was a problem hiding this comment.
One thing we could look into (not that it saves that many lines) is keeping these versions in the workspace root and have the crates pull from that source of truth like that quinn workspace does. Might just be nice with this long hashes.
Collaborator
Author
There was a problem hiding this comment.
Will give that a look. Sounds like good practice
Collaborator
|
cACK I am curious about the longterm |
rustaceanrob
force-pushed
the
rust-bitcoin-dev-7-24
branch
from
5d290c5 to
7fe268e
Compare
rustaceanrob
force-pushed
the
rust-bitcoin-dev-7-24
branch
from
7fe268e to
be8b4ed
Compare
Collaborator
Author
|
After having a look at the dependency tree and iterating a few times, looks like we will probably remove the dependency entirely. I'll tackle this in a separate PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes use of the new
V2NetworkMessageapart of the newp2ptypes crate.This temporarily removes
no_stdbecausep2pisstd, but an easy fix would be internal conversions forNetwork -> [u8; 4]when dealing with magic, which is only one place.Removes the
serdemodule which is a nice win.Proposing that we add this to a "develop" branch