Merged
Conversation
Simplifying the protocol crate's interface by dropping the more general futures flag in favor of just the tokio one. All users of the library have been tokio runtime users. If the rust standard library gets its act together and adopts some async I/O interfaces, those will be used in the future instead. Until then, simplifying the interface to explore other things like ffi bindings.
Adding a std protocol will clean up all these gates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifying the protocol crate's interface by dropping the more general futures flag in favor of just the tokio one. All users of the library have been tokio runtime users. If the rust standard library gets its act together and adopts some async I/O interfaces, those will be used in the future instead. Until then, simplifying the interface to explore other things like ffi bindings.