Skip to content

Null-safety support #10

Open
OZEO-DOOZ wants to merge 5 commits intorushio-consulting:masterfrom
OZEO-DOOZ:master
Open

Null-safety support #10
OZEO-DOOZ wants to merge 5 commits intorushio-consulting:masterfrom
OZEO-DOOZ:master

Conversation

@OZEO-DOOZ
Copy link

Hi @kleak,
Here is a PR to upgrade your router pkg towards null-safety... Until it is merged, we will use our fork on our app 👍
We did the migration without the official tool for nnbd migration. If you see anything to change again, please make sure to ping us !

Regards,
@R0m4in-dooz

PS: Maybe we could also work for a version with Navigator API 2.0 ?

@kevin-sakemaer
Copy link

Hi @R0m4in-dooz,
Thanks a lot for this PR this is really great !
Will take a look asap :)

I have started a new project to experiment with Navigator 2.0 (flouter) but i would suggest you to migrate to more robust package for Navigator 2.0 like beamer.

.... 10 minutes later

I looked at the code and everything looks good will try it this evening and merge it :)

@ghost
Copy link

ghost commented Aug 14, 2021

As this pkg is used in production in our app without any issues, I added version change to 1.0.0 😁 If you want me to undo this precise change, tell me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants