Skip to content

Update goal-tracker to v2.0.0#9086

Merged
LlemonDuck merged 3 commits intorunelite:masterfrom
Toofifty:master
Nov 14, 2025
Merged

Update goal-tracker to v2.0.0#9086
LlemonDuck merged 3 commits intorunelite:masterfrom
Toofifty:master

Conversation

@Toofifty
Copy link
Contributor

Includes major updates by @AhDoozy Toofifty/rl-goal-tracker#42

@runelite-github-app
Copy link

runelite-github-app bot commented Sep 18, 2025

@tylerwgrass
Copy link
Member

tylerwgrass commented Sep 18, 2025

Reflection is not allowed: https://github.com/Toofifty/rl-goal-tracker/compare/3661001242cdc86e0139fbaceba46bd10ff222f0..Toofifty:a327f53a7496ad7c842f80c20b75fc89b4568caf#diff-dab3f93c8c7875541d90ebf24d0a3d4f90577a0588e06f91f452ef8b9a5c0f82R5

You are also adding a new unverified dependency. Without looking how you are using it, I'd recommend removing it otherwise you will need to go through additional dependency verification which will add a lot of time to review.

@tylerwgrass tylerwgrass added the waiting for author waiting for the pr author to make changes or respond to questions label Sep 18, 2025
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Sep 22, 2025
@Toofifty
Copy link
Contributor Author

Thanks, issues addressed in Toofifty/rl-goal-tracker#47

@runelite-github-app
Copy link

runelite-github-app bot commented Sep 22, 2025

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@jsparidaans
Copy link

would love to see this update!

@DjilanoS
Copy link

@tylerwgrass Any chance this can be reviewed soon? Thanks.

@cdfisher
Copy link
Contributor

This is a pretty big PR to review, you just need to be patient.

@DjilanoS
Copy link

This is a pretty big PR to review, you just need to be patient.

We are patient, but we're also free to ask for this plugin to be reviewed :)

@LlemonDuck LlemonDuck merged commit bb4b696 into runelite:master Nov 14, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants