fix: skip KWOK PrometheusRule when CRD is not available#171
Merged
Conversation
The centralized KWOK status-exporter produces DCGM metrics for virtual GPU nodes, but RunAI's recording rules derive the node label by joining with kube_pod_info on the exporter pod IP. Since the centralized pod runs on a system node, KWOK GPU metrics were attributed to the wrong node and never appeared in the UI. Changes: - Set Hostname label to the actual KWOK node name in multi_node_exporter so metrics can be correlated to the correct virtual node - Add a dedicated Service for the KWOK exporter with component selector to prevent the DaemonSet service from also matching KWOK pods - Add component label to DaemonSet pod template to distinguish from KWOK - Create a PrometheusRule (deployed to runai namespace) that produces runai_dcgm_gpu_utilization, runai_dcgm_gpu_used_mebibytes, and runai_dcgm_gpu_total_mebibytes recording rules using Hostname as the node label, bypassing the kube_pod_info join Fixes: RUN-36987
Add statusExporter.kwok.prometheusRule.enabled (default true) to allow disabling the KWOK DCGM recording rules without affecting the rest of the status-exporter. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add .Capabilities.APIVersions check so the KWOK PrometheusRule is only rendered on clusters that have the Prometheus Operator installed. Fixes integration test failures on clusters without the CRD. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan