fix: KWOK node GPU metrics not visible in RunAI UI#170
Merged
Conversation
The centralized KWOK status-exporter produces DCGM metrics for virtual GPU nodes, but RunAI's recording rules derive the node label by joining with kube_pod_info on the exporter pod IP. Since the centralized pod runs on a system node, KWOK GPU metrics were attributed to the wrong node and never appeared in the UI. Changes: - Set Hostname label to the actual KWOK node name in multi_node_exporter so metrics can be correlated to the correct virtual node - Add a dedicated Service for the KWOK exporter with component selector to prevent the DaemonSet service from also matching KWOK pods - Add component label to DaemonSet pod template to distinguish from KWOK - Create a PrometheusRule (deployed to runai namespace) that produces runai_dcgm_gpu_utilization, runai_dcgm_gpu_used_mebibytes, and runai_dcgm_gpu_total_mebibytes recording rules using Hostname as the node label, bypassing the kube_pod_info join Fixes: RUN-36987
eliranw
commented
Feb 22, 2026
Contributor
Author
eliranw
left a comment
There was a problem hiding this comment.
Clean, well-documented fix. The approach of creating parallel PrometheusRules with direct Hostname-to-node mapping is a good solution for the KWOK centralized exporter scenario. A few minor observations below.
deploy/fake-gpu-operator/templates/status-exporter/kwok-prometheusrule.yaml
Show resolved
Hide resolved
noaamran
approved these changes
Feb 23, 2026
Add statusExporter.kwok.prometheusRule.enabled (default true) to allow disabling the KWOK DCGM recording rules without affecting the rest of the status-exporter. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dcgmMetricsRulerecording rules join DCGM metrics withkube_pod_infoonpod_ipto derive thenodelabel. For the centralized KWOK exporter, this maps metrics to the system node where the pod runs, not to the virtual KWOK node.Changes
multi_node_exporter.go: Override theHostnamelabel with the actual KWOK node name (instead of a hash) so metrics can be correlated to the correct virtual nodekwok-service.yaml(new): Dedicated Service for the KWOK exporter withcomponent: status-exporter-kwokselectorkwok-prometheusrule.yaml(new): PrometheusRule deployed torunainamespace that createsrunai_dcgm_gpu_utilization,runai_dcgm_gpu_used_mebibytes, andrunai_dcgm_gpu_total_mebibytesrecording rules usingHostnamedirectly as thenodelabel, bypassing thekube_pod_infojoinservice.yaml: Addedcomponent: status-exporterto selector to prevent the DaemonSet service from matching KWOK pods (avoids double-scraping)_helpers.tpl: Addedcomponent: status-exporterlabel to DaemonSet pod templateHow it works
The PrometheusRule uses
label_replaceto setnodefrom theHostnamelabel, then joins withrunai_node_nodepool_excludedto add thenodepoollabel. Regular (non-KWOK) metrics have a hash-basedHostnamethat doesn't match any real node, so they are naturally filtered out by the join.Test plan
runai_dcgm_gpu_utilization,runai_dcgm_gpu_used_mebibytes,runai_dcgm_gpu_total_mebibytesshow correct values for KWOK nodes in Prometheus