Merged
Conversation
Add new kwok-compute-domain-dra-plugin component that creates ResourceSlices for compute domain channels on KWOK simulated nodes. Key changes: - New internal/kwok-compute-domain-dra-plugin package with Node controller - Controller watches nodes with label type=kwok or annotation kwok.x-k8s.io/node=fake - Creates ResourceSlice named kwok-<node>-compute-domain-channel for each KWOK node - ResourceSlice contains channel-0 device for compute domain allocation - New cmd/kwok-compute-domain-dra-plugin entrypoint - Updated Dockerfile and Makefile to build new component
Add new Helm values block for KWOK compute-domain DRA plugin: - kwokComputeDomainDraPlugin.enabled (default: false) - image configuration - resource requests/limits
Add Helm templates for KWOK compute-domain DRA plugin deployment: - deployment.yaml: single replica Deployment with no host volumes - serviceaccount.yaml: dedicated service account - clusterrole.yaml: permissions for nodes and resourceslices - clusterrolebinding.yaml: binds role to service account All templates gated by kwokComputeDomainDraPlugin.enabled flag.
Update integration test harness: - Enable kwokComputeDomainDraPlugin in values.yaml - Load kwok-compute-domain-dra-plugin image into kind cluster - Pass image tag to helm install - Wait for kwok-compute-domain-dra-plugin deployment readiness
Add integration tests for compute-domain on KWOK nodes: - Test manifest: compute-domain-kwok-pod.yaml with ComputeDomain CR and Pod targeting KWOK node with nodeSelector and tolerations - Test: ResourceSlice created for KWOK nodes with compute-domain channels - Test: Pod scheduled on KWOK node can allocate compute-domain claim - Test: ComputeDomain status updated to Ready with KWOK node listed
enoodle
force-pushed
the
erez/compute-domain-kwok
branch
from
8ccd519 to
e8eb57b
Compare
SiorMeir
reviewed
Feb 1, 2026
| } | ||
|
|
||
| if err := r.createOrUpdateResourceSlice(ctx, &node); err != nil { | ||
| log.Printf("Failed to create/update ResourceSlice for node %s: %v", node.Name, err) |
There was a problem hiding this comment.
will the log level here be automatically ERROR? if not should we set it to be?
Contributor
Author
There was a problem hiding this comment.
You are right. I will look at all t the logs here to verify they use correct conventions
SiorMeir
approved these changes
Feb 1, 2026
replace log with klog for structured logging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.