Fix: Right hand reset_motors.py integer underflow issue#2
Open
kywch wants to merge 2 commits intoruka-hand:mainfrom
Open
Fix: Right hand reset_motors.py integer underflow issue#2kywch wants to merge 2 commits intoruka-hand:mainfrom
kywch wants to merge 2 commits intoruka-hand:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for making the RUKA hand!
When using
reset_motors.pywith the right hand, the hand'sself.tensioned_poswas set to 0. It caused integer underflow, resulting in erratic motor positions with large values like 4294967295.Adding 100 to
self.tensioned_posfixed it and produced the output like: