Open
Conversation
* Right now direct IO is a net negative until we can implement Async Direct io(ref: https://www.scylladb.com/2017/10/05/io-access-methods-scylla/). * using fallocate(FALLOC_FL_KEEP_SIZE) on Linux. * Simply WAL writes with buffered io(risk losing data on kernel crashes). * Make the header read only therefore. * Remove cascading locks on WAL since it already had interior mutability. * Replace RwLock with ArcSwap on Active memtable. More at docs/performance-profiling-2025-10-08.md. * Since the header is read only we don't need to represent it in memory, therefore eliminating the need for the associated lock that was getting in the way of perfomance. See: docs/wal-header-design-flaw-2025-10-08.md All in all we halved the number of futex calls per transaction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a simple benchmark harness(to be improved)
WAL changes
Direct io(ref: https://www.scylladb.com/2017/10/05/io-access-methods-scylla/).
crashes).
Reducing lock contention on the hot path.
mutability.
docs/performance-profiling-2025-10-08.md.
therefore eliminating the need for the associated lock that was
getting in the way of perfomance. See: docs/wal-header-design-flaw-2025-10-08.md
All in all we halved the number of futex calls per transaction