avm1: Improve loading a movie into root #22896
Open
+539
−96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the code more readable.
1. Do not special case initial state when loading local movies. 2. Set the new URL for the initial loading state. There's no evidence that local movies have an error state loaded initially or that the initial state uses the old URL, there's even evidence to the contrary: when replacing the root movie we have a pretty deep insight on what the movie looks like.
Looks like it's an exception for when the root movie is being replaced, as in other cases the name is not being reset.
Flash invokes loader listeners when the root movie is replaced. Those listeners are executed in the content of the old root movie, or the new one when replaced.
kjarosh
added
A-avm1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains several patches that improve how Ruffle behaves when loading a movie into _root. The basis for tests constitute the loader listener events, using which we can observe various states of the movie during loading.