improve code organization with packages#475
Open
ruebenramirez wants to merge 2 commits intomasterfrom
Open
Conversation
ruebenramirez
commented
Nov 16, 2023
| return blogTitle | ||
| } | ||
|
|
||
| func ScrapePost(postUrl string, titleSelector string, postSelector string) (string, string) { |
Owner
Author
There was a problem hiding this comment.
exported function requires a name that starts with a capital letter (https://go.dev/tour/basics/3)
ruebenramirez
commented
Nov 16, 2023
|
|
||
| // example usage | ||
| postUrl := "https://blog.ruebenramirez.com/posts/2023-11-05-celebratin-60-pounds-down/" | ||
| title, postHtml := lib.ScrapePost(postUrl, titleSelector, postSelector) |
Owner
Author
There was a problem hiding this comment.
Calling the exported function from the lib package.
ruebenramirez
commented
Nov 16, 2023
| import ( | ||
| "fmt" | ||
|
|
||
| "bopbot/newsletter/scrape/lib" |
Owner
Author
There was a problem hiding this comment.
importing scrape's lib package
ruebenramirez
commented
Nov 16, 2023
| @@ -0,0 +1,26 @@ | |||
| package lib | |||
Owner
Author
There was a problem hiding this comment.
utils.go is a member of scrape's lib package
ruebenramirez
commented
Nov 16, 2023
| @@ -0,0 +1,55 @@ | |||
| package lib | |||
Owner
Author
There was a problem hiding this comment.
scrape.go is a member of scrape's lib package
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.