Implement lazy module loading for nested module access#884
Open
seth-schultz wants to merge 2 commits intorue-language:trunkfrom
Open
Implement lazy module loading for nested module access#884seth-schultz wants to merge 2 commits intorue-language:trunkfrom
seth-schultz wants to merge 2 commits intorue-language:trunkfrom
Conversation
- Enable Zola's built-in search index in config.toml - Add elasticlunr-based search.js for client-side search - Add search input to spec sidebar with keyboard shortcut (Cmd/Ctrl+K) - Add CSS styles for search UI with light/dark mode support The search indexes all spec pages and shows results in a dropdown with titles and body snippets.
Add module_loader.rs for on-demand scanning of module exports when first accessed (e.g., std.math.abs()). This fixes nested module member access which was claimed to work in ADR-0026 but didn't. Changes: - Add ModuleDef export tracking (functions, structs, enums, constants) - Create module_loader.rs for lazy export scanning - Extract check_visibility() helper to reduce duplication - Clean up types.rs docstrings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements lazy module loading to fix nested module member access (e.g.,
std.math.abs()).Problem
ADR-0026 claimed nested module access worked, but it didn't. Accessing
std.math.abs()would fail because module exports weren't being loaded on demand.Solution
ModuleDefexport tracking (functions, structs, enums, constants with visibility)module_loader.rsfor lazy scanning of module exports when first accessedcheck_visibility()helper to reduce code duplication inanalyze_ops.rstypes.rsdocstringsTesting