Improve hello.rue example and remove linker debug output#882
Open
seth-schultz wants to merge 2 commits intorue-language:trunkfrom
Open
Improve hello.rue example and remove linker debug output#882seth-schultz wants to merge 2 commits intorue-language:trunkfrom
seth-schultz wants to merge 2 commits intorue-language:trunkfrom
Conversation
The classic first program should actually print something!
These eprintln! statements were printing 200+ DEBUG lines during normal compilation. Removed all unconditional debug output and converted the text_file_offset sanity check to a debug_assert.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two quality-of-life improvements:
1. Update hello.rue to print
Hello, World!The classic first program should actually print something! Updated from just returning
42to using@dbgto print the greeting.2. Remove debug print statements from linker
The linker was printing 200+
DEBUG:lines during normal compilation. Removed all unconditional debug output from:crates/rue-linker/src/linker.rscrates/rue-linker/src/macho.rsAlso converted a sanity check from
eprintln!todebug_assert_eq!for the text_file_offset verification.Testing
./quick-test.shpasses./buck2 run //crates/rue-spec:rue-spec -- "arithmetic"passes (70 tests)hello.ruecompiles and runs correctly